fix #5544: enlarge dropdown for external source import

[guillermo-escire]

References

Fixes #5544

Description

Enlarges the external source dropdown in the Import from External Sources page by increasing the initial page size from 5 to 20 and fixing the dropdown max-height CSS to allow proper scrolling.

Instructions for Reviewers

List of changes in this PR:

• Increased elementsPerPage from 5 to 20 in submission-import-external-searchbar.component.ts (both in ngOnInit and onScroll) so more sources are loaded initially.
• Updated .scrollable-menu max-height in submission-import-external-searchbar.component.scss from calc(var(--ds-dropdown-menu-max-height) / 2) to calc(var(--ds-dropdown-menu-max-height) * 2) and added overflow-y: auto to enable scrolling.
• Added/updated specs in submission-import-external-searchbar.component.spec.ts to reflect the new elementsPerPage value.

How to test:

1. Go to My DSpace
2. Click the import button (↵) and select "Publicación"
3. On the "Import a publication from an external source" page, click the source dropdown (e.g. "arXiv")
4. Verify the dropdown is larger and shows more than 5 options with scroll

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[kanasznagyzoltan]

I have tested. For me the list of changes made by this PR is appeared.
I have compared the current sandbox vs this PR branch.

pr_5622.mp4

[nathanmlf]

I have tested it and it works fine. For reference, I've attached a screenshot from the DSpace sandbox and one using your implementation.

DSpace sandbox:

New implementation:

Great job @guillermo-escire !

[GauravD2t]

Thanks, @guillermo-escire! I verified the behavior locally.

[tdonohue]

👍 Thanks @guillermo-escire ! This looks good to me too. I tested it and I like the larger sized dropdown.

[dspace-bot]

Successfully created backport PR for dspace-7_x:

• [Port dspace-7_x] fix #5544: enlarge dropdown for external source import #5669

[dspace-bot]

Successfully created backport PR for dspace-8_x:

• [Port dspace-8_x] fix #5544: enlarge dropdown for external source import #5670

[dspace-bot]

Successfully created backport PR for dspace-9_x:

• [Port dspace-9_x] fix #5544: enlarge dropdown for external source import #5671