Add tsv mimeType support and raise clear error for xlsx in WQP#232
Draft
thodson-usgs wants to merge 1 commit intoDOI-USGS:mainfrom
Draft
Add tsv mimeType support and raise clear error for xlsx in WQP#232thodson-usgs wants to merge 1 commit intoDOI-USGS:mainfrom
thodson-usgs wants to merge 1 commit intoDOI-USGS:mainfrom
Conversation
_check_kwargs now accepts 'tsv' as a valid mimeType alongside 'csv', raises NotImplementedError for 'xlsx' (not yet supported), and gives a clearer ValueError message for any other invalid value. A new _read_wqp_response helper replaces the nine hardcoded pd.read_csv calls, using a tab delimiter when mimeType='tsv' and a comma otherwise. Closes DOI-USGS#162. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162
Summary
_check_kwargsnow acceptsmimeType='tsv'alongside'csv'for legacy WQP callsmimeType='xlsx'raisesNotImplementedErrorwith a clear message (xlsx support is not yet implemented)ValueError: Invalid mimeType. Supported options: 'csv', 'tsv'._read_wqp_response(text, kwargs)helper that replaces 9 identicalpd.read_csv(..., delimiter=",")calls — uses\tdelimiter whenmimeType='tsv',,otherwiseNote: tsv support applies to legacy WQP calls only. WQX3.0 endpoints only support csv at this time, as noted in the original issue.
Test plan
test_check_kwargsupdated to covertsv(passes),xlsx(NotImplementedError), and unchanged casestest_get_results_tsvadded: mocks a tab-delimited response and verifies it is parsed correctly🤖 Generated with Claude Code