NPM - #149
Open
jrcain-usgs wants to merge 3 commits into
Open
Conversation
Kelvinrr
reviewed
Aug 3, 2026
Comment on lines
16
to
+118
| @@ -103,3 +104,15 @@ jobs: | |||
| run: | | |||
| gh release upload "${{ steps.package.outputs.tag }}" \ | |||
| "${{ steps.package.outputs.asset }}" --clobber | |||
|
|
|||
| - uses: actions/setup-node@v6 | |||
| with: | |||
| node-version: '24' | |||
| registry-url: 'https://registry.npmjs.org' | |||
| package-manager-cache: false | |||
|
|
|||
| - name: Publish to NPM | |||
| run: | | |||
| npm install -g npm@latest # ensure OIDC-capable npm (>= 11.5.1) | |||
| npm install | |||
| npm publish | |||
Collaborator
There was a problem hiding this comment.
is it possible for this to be ran manually? Therefore, it could overwrite the existing build? Maybe we only want it to run on release?
| spiceql.mountKernel('/kernels/naif0012.tls', bytes); | ||
|
|
||
| const { result } = spiceql.utcToEt('2000-01-01T00:00:00', { | ||
| const { result, kernels } = spiceql.utcToEt('2000-01-01T00:00:00', { |
Collaborator
There was a problem hiding this comment.
might not be the best example in hindsight, UTC2et doesn't need an LSK in SpiceQL. But we can leave as is and make an issue about changing this example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: