Skip to content

add check for libspdm_read_* APIs in unit test #3622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jyao1 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add check for libspdm_read_* APIs in unit test #3622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
956b0a1
unit_test/fuzzing: add return value checks for libspdm_read_* APIs
jyao1 May 13, 2026
c13f443
unit_test/test_spdm_common: add return value checks for libspdm_read_…
jyao1 May 13, 2026
be92629
unit_test/test_spdm_crypt: add return value checks for libspdm_read_*…
jyao1 May 13, 2026
32214dd
unit_test/test_spdm_requester: add return value checks for libspdm_re…
jyao1 May 13, 2026
d398fd9
unit_test/test_spdm_responder: add return value checks for libspdm_re…
jyao1 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions unit_test/fuzzing/test_requester/test_spdm_requester_challenge/challenge.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,12 @@ libspdm_return_t libspdm_device_receive_message(void *spdm_context, size_t *resp
sizeof(temp_buf) - test_message_header_size,
(uint8_t *)spdm_test_context->test_buffer,
spdm_response_size);
libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
NULL, NULL);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
NULL, NULL)) {
return LIBSPDM_STATUS_RECEIVE_FAIL;
}
((libspdm_context_t *)spdm_context)->local_context.local_cert_chain_provision_size[0] =
data_size;
((libspdm_context_t *)spdm_context)->local_context.local_cert_chain_provision[0] = data;
Expand Down Expand Up @@ -132,10 +134,12 @@ void libspdm_test_requester_challenge_case1(void **State)
spdm_context->connection_info.connection_state = LIBSPDM_CONNECTION_STATE_NEGOTIATED;
spdm_context->connection_info.capability.flags = 0;
spdm_context->connection_info.capability.flags |= SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_CHAL_CAP;
libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size)) {
return;
}
libspdm_reset_message_a(spdm_context);
libspdm_reset_message_b(spdm_context);
libspdm_reset_message_c(spdm_context);
Expand Down Expand Up @@ -194,10 +198,12 @@ void libspdm_test_requester_challenge_ex_case1(void **State)
spdm_context->connection_info.connection_state = LIBSPDM_CONNECTION_STATE_NEGOTIATED;
spdm_context->connection_info.capability.flags = 0;
spdm_context->connection_info.capability.flags |= SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_CHAL_CAP;
libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size)) {
return;
}
libspdm_reset_message_a(spdm_context);
libspdm_reset_message_b(spdm_context);
libspdm_reset_message_c(spdm_context);
Expand Down
10 changes: 6 additions & 4 deletions unit_test/fuzzing/test_requester/test_spdm_requester_encap_certificate/encap_certificate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,12 @@ void libspdm_test_requester_encap_certificate(void **State)
request_size = sizeof(spdm_get_certificate_request_t);
}

libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
NULL, NULL);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
NULL, NULL)) {
return;
}

spdm_context->local_context.local_cert_chain_provision[slot_id] = data;
spdm_context->local_context.local_cert_chain_provision_size[slot_id] = data_size;
Expand Down
10 changes: 6 additions & 4 deletions ...st/fuzzing/test_requester/test_spdm_requester_encap_challenge_auth/encap_challenge_auth.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,12 @@ void libspdm_test_requester_encap_challenge(void **State)

spdm_context->connection_info.version = SPDM_MESSAGE_VERSION_11
<< SPDM_VERSION_NUMBER_SHIFT_BIT;
libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
NULL, NULL);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
NULL, NULL)) {
return;
}
spdm_context->local_context.local_cert_chain_provision[0] = data;
spdm_context->local_context.local_cert_chain_provision_size[0] = data_size;

Expand Down
20 changes: 12 additions & 8 deletions unit_test/fuzzing/test_requester/test_spdm_requester_encap_request/encap_request.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,12 @@ void libspdm_test_requester_encap_request(void **State)
spdm_context->local_context.capability.flags |= SPDM_GET_CAPABILITIES_REQUEST_FLAGS_ENCAP_CAP;
spdm_context->connection_info.capability.flags |=
SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_ENCAP_CAP;
libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size)) {
return;
}
libspdm_reset_message_a(spdm_context);
spdm_context->connection_info.algorithm.base_hash_algo = m_libspdm_use_hash_algo;
spdm_context->connection_info.algorithm.base_asym_algo = m_libspdm_use_asym_algo;
Expand Down Expand Up @@ -210,10 +212,12 @@ void libspdm_test_requester_encap_request_case2(void **State)
spdm_context->local_context.capability.flags |= SPDM_GET_CAPABILITIES_REQUEST_FLAGS_ENCAP_CAP;
spdm_context->connection_info.capability.flags |=
SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_ENCAP_CAP;
libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size)) {
return;
}
libspdm_reset_message_a(spdm_context);
spdm_context->connection_info.algorithm.base_hash_algo = m_libspdm_use_hash_algo;
spdm_context->connection_info.algorithm.base_asym_algo = m_libspdm_use_asym_algo;
Expand Down
10 changes: 6 additions & 4 deletions unit_test/fuzzing/test_requester/test_spdm_requester_end_session/end_session.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,12 @@ void libspdm_test_requester_end_session(void **State)
spdm_context->local_context.capability.flags |= SPDM_GET_CAPABILITIES_REQUEST_FLAGS_PSK_CAP;
spdm_context->local_context.capability.flags |= SPDM_GET_CAPABILITIES_REQUEST_FLAGS_ENCRYPT_CAP;
spdm_context->local_context.capability.flags |= SPDM_GET_CAPABILITIES_REQUEST_FLAGS_MAC_CAP;
libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size)) {
return;
}
libspdm_reset_message_a(spdm_context);
spdm_context->connection_info.algorithm.base_hash_algo =
m_libspdm_use_hash_algo;
Expand Down
38 changes: 23 additions & 15 deletions unit_test/fuzzing/test_requester/test_spdm_requester_finish/finish.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,12 @@ void libspdm_test_send_receive_finish_case1(void **State)
spdm_context->local_context.capability.flags |=
SPDM_GET_CAPABILITIES_REQUEST_FLAGS_MAC_CAP;

libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size)) {
return;
}
libspdm_reset_message_a(spdm_context);
spdm_context->connection_info.algorithm.base_hash_algo = m_libspdm_use_hash_algo;
spdm_context->connection_info.algorithm.base_asym_algo = m_libspdm_use_asym_algo;
Expand Down Expand Up @@ -187,10 +189,12 @@ void libspdm_test_send_receive_finish_case2(void **State)
spdm_context->local_context.capability.flags |=
SPDM_GET_CAPABILITIES_REQUEST_FLAGS_MAC_CAP;

libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size)) {
return;
}
libspdm_reset_message_a(spdm_context);
spdm_context->connection_info.algorithm.base_hash_algo = m_libspdm_use_hash_algo;
spdm_context->connection_info.algorithm.base_asym_algo = m_libspdm_use_asym_algo;
Expand Down Expand Up @@ -277,10 +281,12 @@ void libspdm_test_send_receive_finish_case3(void **State)
spdm_context->local_context.capability.flags |=
SPDM_GET_CAPABILITIES_REQUEST_FLAGS_MAC_CAP;

libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size)) {
return;
}
libspdm_reset_message_a(spdm_context);
spdm_context->connection_info.algorithm.base_hash_algo = m_libspdm_use_hash_algo;
spdm_context->connection_info.algorithm.base_asym_algo = m_libspdm_use_asym_algo;
Expand Down Expand Up @@ -310,9 +316,11 @@ void libspdm_test_send_receive_finish_case3(void **State)

free(data);
req_slot_id_param = 0;
libspdm_read_requester_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_req_asym_algo, &data,
&data_size, &hash, &hash_size);
if (!libspdm_read_requester_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_req_asym_algo, &data,
&data_size, &hash, &hash_size)) {
return;
}
spdm_context->local_context.local_cert_chain_provision_size[req_slot_id_param] = data_size;
spdm_context->local_context.local_cert_chain_provision[req_slot_id_param] = data;

Expand Down
48 changes: 29 additions & 19 deletions unit_test/fuzzing/test_requester/test_spdm_requester_get_certificate/get_certificate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,12 @@ void libspdm_test_requester_get_certificate_case1(void **State)

spdm_context->local_context.is_requester = true;

libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size)) {
return;
}
libspdm_x509_get_cert_from_cert_chain((uint8_t *)data + sizeof(spdm_cert_chain_t) + hash_size,
data_size - sizeof(spdm_cert_chain_t) - hash_size, 0,
&root_cert,
Expand Down Expand Up @@ -157,10 +159,12 @@ void libspdm_test_requester_get_certificate_case2(void **State)
spdm_context->local_context.is_requester = true;
libspdm_register_verify_spdm_cert_chain_func (spdm_context,
libspdm_test_verify_spdm_cert_chain);
libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size)) {
return;
}
libspdm_x509_get_cert_from_cert_chain((uint8_t *)data + sizeof(spdm_cert_chain_t) + hash_size,
data_size - sizeof(spdm_cert_chain_t) - hash_size, 0,
&root_cert,
Expand Down Expand Up @@ -218,10 +222,12 @@ void libspdm_test_requester_get_certificate_case3(void **State)

spdm_context->local_context.is_requester = true;

libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size)) {
return;
}
libspdm_x509_get_cert_from_cert_chain((uint8_t *)data + sizeof(spdm_cert_chain_t) + hash_size,
data_size - sizeof(spdm_cert_chain_t) - hash_size, 0,
&root_cert,
Expand Down Expand Up @@ -277,10 +283,12 @@ void libspdm_test_requester_get_certificate_ex_case1(void **State)
spdm_context->local_context.is_requester = true;
libspdm_register_verify_spdm_cert_chain_func (spdm_context,
libspdm_test_verify_spdm_cert_chain);
libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size,
&hash, &hash_size)) {
return;
}
libspdm_x509_get_cert_from_cert_chain((uint8_t *)data + sizeof(spdm_cert_chain_t) + hash_size,
data_size - sizeof(spdm_cert_chain_t) - hash_size, 0,
&root_cert,
Expand Down Expand Up @@ -360,9 +368,11 @@ void libspdm_test_requester_get_certificate_in_session_case1(void **State)
m_libspdm_use_aead_algo;
spdm_context->local_context.is_requester = true;

libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size, &hash, &hash_size);
if (!libspdm_read_responder_public_certificate_chain(m_libspdm_use_hash_algo,
m_libspdm_use_asym_algo, &data,
&data_size, &hash, &hash_size)) {
return;
}
libspdm_x509_get_cert_from_cert_chain((uint8_t *)data + sizeof(spdm_cert_chain_t) + hash_size,
data_size - sizeof(spdm_cert_chain_t) - hash_size, 0,
&root_cert, &root_cert_size);
Expand Down
Loading
Loading