Skip to content

Chunk interrupt handling #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jyao1 wants to merge 2 commits into
base: main
Choose a base branch
from
+357 −16
Open

Chunk interrupt handling #3615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c570ad
Keep chunk sequence except GET_VERSION.
jyao1 Apr 27, 2026
135d4da
Add more test for CHUNK_send/get for msg interrupt.
jyao1 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 40 additions & 16 deletions library/spdm_responder_lib/libspdm_rsp_receive_send.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,29 +556,52 @@ libspdm_return_t libspdm_build_response(void *spdm_context, const uint32_t *sess
get_response_func = libspdm_get_response_func_via_last_request(context);

#if LIBSPDM_ENABLE_CAPABILITY_CHUNK_CAP
/* If responder is expecting chunk_get or chunk_send requests
* and gets other requests instead, drop out of chunking mode */
/* Per DSP0274: The chunked transfer shall not be interrupted by any commands
* that are not part of the chunk transfer sequence, with the exception of
* GET_VERSION. The Responder shall return ErrorCode=UnexpectedRequest if an
* unexpected command is received during the chunked transfer. These error codes
* shall not interrupt the chunk transfer sequence. */
if (context->chunk_context.get.chunk_in_use
&& get_response_func != libspdm_get_response_chunk_get) {

context->chunk_context.get.chunk_in_use = false;
context->chunk_context.get.chunk_handle++; /* implicit wrap - around to 0. */
context->chunk_context.get.chunk_seq_no = 0;

context->chunk_context.get.large_message = NULL;
context->chunk_context.get.large_message_size = 0;
context->chunk_context.get.chunk_bytes_transferred = 0;
if (get_response_func == libspdm_get_response_version) {
/* GET_VERSION is allowed to interrupt chunk transfer.
* Reset chunk get context and proceed normally. */
context->chunk_context.get.chunk_in_use = false;
context->chunk_context.get.chunk_handle++;
context->chunk_context.get.chunk_seq_no = 0;
context->chunk_context.get.large_message = NULL;
context->chunk_context.get.large_message_size = 0;
context->chunk_context.get.chunk_bytes_transferred = 0;
} else {
/* Reject with UnexpectedRequest without terminating
* the chunk transfer sequence. */
status = libspdm_generate_error_response(
context, SPDM_ERROR_CODE_UNEXPECTED_REQUEST, 0,
&my_response_size, my_response);
goto response_dispatched;
}
}
if (context->chunk_context.send.chunk_in_use
&& get_response_func != libspdm_get_response_chunk_send) {

context->chunk_context.send.chunk_in_use = false;
context->chunk_context.send.chunk_handle = 0;
context->chunk_context.send.chunk_seq_no = 0;

context->chunk_context.send.large_message = NULL;
context->chunk_context.send.large_message_size = 0;
context->chunk_context.send.chunk_bytes_transferred = 0;
if (get_response_func == libspdm_get_response_version) {
/* GET_VERSION is allowed to interrupt chunk transfer.
* Reset chunk send context and proceed normally. */
context->chunk_context.send.chunk_in_use = false;
context->chunk_context.send.chunk_handle = 0;
context->chunk_context.send.chunk_seq_no = 0;
context->chunk_context.send.large_message = NULL;
context->chunk_context.send.large_message_size = 0;
context->chunk_context.send.chunk_bytes_transferred = 0;
} else {
/* Reject with UnexpectedRequest without terminating
* the chunk transfer sequence. */
status = libspdm_generate_error_response(
context, SPDM_ERROR_CODE_UNEXPECTED_REQUEST, 0,
&my_response_size, my_response);
goto response_dispatched;
}
}
#endif /* LIBSPDM_ENABLE_CAPABILITY_CHUNK_CAP */

Expand All @@ -603,6 +626,7 @@ libspdm_return_t libspdm_build_response(void *spdm_context, const uint32_t *sess
}

#if LIBSPDM_ENABLE_CAPABILITY_CHUNK_CAP
response_dispatched:
if (libspdm_get_connection_version(context) < SPDM_MESSAGE_VERSION_14) {
chunk_send_ack_response_header_size = sizeof(spdm_chunk_send_ack_response_t);
} else {
Expand Down
Loading
Loading