Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
github-actions
bot
added
the
auto: not ready to review
Contributor
|
test |
Contributor
|
Successfully generated as following: http://localhost:1200/projectjav/actress/ibuki-aoi-20076 - Failed ❌http://localhost:1200/projectjav/actress/rima-arai-22198/ - Failed ❌ |
Contributor
Auto ReviewNo clear rule violations found in the current diff. |
Author
Maybe Github IPs are blocked? This has been working for months for me. |
TonyRL
reviewed
Apr 3, 2026
Collaborator
TonyRL
left a comment
TonyRL
left a comment
There was a problem hiding this comment.
Please fix all the lint issues as well
lib/routes/projectjav/actress.ts
Outdated
| import { rootUrl, processItems } from './utils'; | ||
|
|
||
| export const route: Route = { | ||
| path: ['/actress/:id', '/actress/:id/'], |
lib/routes/projectjav/actress.ts
Outdated
| async function handler(ctx) { | ||
| const id = ctx.req.param('id'); | ||
| const currentUrl = `${rootUrl}/actress/${id}`; | ||
| return await processItems(currentUrl, cache.tryGet); |
Collaborator
There was a problem hiding this comment.
The whole cache.tryGet function can be imported directly. No need to pass it as parameter.
github-actions
bot
removed
the
auto: not ready to review
Contributor
|
Successfully generated as following: http://localhost:1200/projectjav/actress/ibuki-aoi-20076 - Failed ❌http://localhost:1200/projectjav/actress/rima-arai-22198/ - Failed ❌ |
github-actions
bot
added
the
auto: not ready to review
github-actions
bot
added
auto: not ready to review
Contributor
|
Successfully generated as following: http://localhost:1200/projectjav/actress/ibuki-aoi-20076 - Failed ❌http://localhost:1200/projectjav/actress/rima-arai-22198/ - Failed ❌ |
Author
|
After removing the second route it didn't work when using a trailing slash, so I added some logic to allow it. |
Contributor
Auto ReviewNo clear rule violations found in the current diff. |
TonyRL
reviewed
Apr 9, 2026
Collaborator
TonyRL
left a comment
TonyRL
left a comment
There was a problem hiding this comment.
Please fix all the lint issues as well
https://github.com/DIYgod/RSSHub/actions/runs/24176816934/job/70560033131?pr=21525
| import { processItems, rootUrl } from './utils'; | ||
|
|
||
| export const route: Route = { | ||
| path: '/actress/:id{[^/]+/?}', |
Collaborator
There was a problem hiding this comment.
Suggested change
| path: '/actress/:id{[^/]+/?}', | |
| path: '/actress/:id', |
Comment on lines
+76
to
+82
| .some((el) => { | ||
| if (content(el).text().includes('Date added')) { | ||
| dateText = content(el).next().text().trim(); | ||
| return true; | ||
| } | ||
| return false; | ||
| }); |
Collaborator
There was a problem hiding this comment.
Use find() instead of some() as you should not have side effects in some()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Involved Issue / 该 PR 相关 Issue
No issue to close
Example for the Proposed Route(s) / 路由地址示例
New RSS Route Checklist / 新 RSS 路由检查表
PuppeteerNote / 说明
No time, only date is given on website. As such I didn't include timezone