Repository navigation
Fix #140, #142, #143, #144, #145, #146 - #149
Merged
Merged
Conversation
It flagged identifiers and domain terms as misspellings, turning docs CI red for non-issues. great-docs lint still runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- create(overwrite=True) validates arguments before deleting (#140) - to_sql escapes single quotes and maps bools to 1/0; by_muid(str) uses it (#144) - Tool progress handlers attach before running; slope warnings surface (#145) - Alternative.scenarios and __eq__ walk scenarios by tree and compare group (#142) - run() raises RuntimeError on non-zero exit or missing results (#143) - Scenario iteration/find_by_name handle duplicate names, AlternativeGroup iterates the whole tree, TopoRepairTool raises on unsupported models, close() always returns None, dead .mupp check removed (#146) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📚 Preview this PR's docs locallyFetch the just-built site and open it in your browser: # this exact build
great-docs preview --run 37310118691
# or always the latest build for this PR
great-docs preview --pr 149Auth & tips
|
Reverts c5a1a12. The words it flagged are .NET and MIKE+ identifiers, so they go in docs/dictionary.txt, which Harper reads in order: an uppercase entry must come before its lowercase twin. Also fixes the prose findings (a missing comma, a mass-noun slip, '50 m.' written out) and rewords two comments and a doctest whose apostrophes the spell check can't take. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140, closes #142, closes #143, closes #144, closes #145, closes #146.
create(overwrite=True)validatessrid/projection_stringbefore deleting anything.to_sqldoubles single quotes and maps bools to1/0;by_muid(str)goes through it.CathSlopeLengthProcessreports its warnings withwarnings.warn.Alternative.scenarioswalks the scenario tree (GetScenarios()returns names, not IDs) and matches on group as well asAltId;Alternative.__eq__compares the group too.run()raisesRuntimeErrorif the engine'sExitCodeis non-zero or a result file is missing, naming the*.log/*ErrorLog.htmlfiles written during the run.db.scenarioswalks the tree fromBaseScenario, so duplicate-named scenarios are distinct;find_by_namereturns all matches.AlternativeGroup.__iter__walks the whole tree.TopoRepairTool.runraisesValueErroron unsupported models.close()always returnsNone.InvalidFileExceptioncheck (imported fromplistlib).ImportTool(config, database=None)and the.muppreading were already fixed on main.Keeps the Harper proofread in
docs-checkand docs CI, with the .NET and MIKE+ identifiers it flagged added todocs/dictionary.txt. Harper reads the dictionary in order, so an uppercase entry must come before its lowercase twin. A few real prose findings are fixed too.Fixes the pre-existing ruff import-sort failure in
mikeplus/tools/__init__.py.Tested locally against MIKE+ 2026: utils, queries, database, scenarios, tools and simulation tests, including slow ones (116 passed). Each fix has a new test.
🤖 Generated with Claude Code