Skip to content

Fix #140, #142, #143, #144, #145, #146 - #149

Merged
ryan-kipawa merged 4 commits into
mainfrom
fix/issues-140-146
Oct 5, 2026
Merged

ryan-kipawa merged 4 commits into
mainfrom
fix/issues-140-146

Conversation

@ryan-kipawa

@ryan-kipawa ryan-kipawa commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #140, closes #142, closes #143, closes #144, closes #145, closes #146.

Keeps the Harper proofread in docs-check and docs CI, with the .NET and MIKE+ identifiers it flagged added to docs/dictionary.txt. Harper reads the dictionary in order, so an uppercase entry must come before its lowercase twin. A few real prose findings are fixed too.

Fixes the pre-existing ruff import-sort failure in mikeplus/tools/__init__.py.

Tested locally against MIKE+ 2026: utils, queries, database, scenarios, tools and simulation tests, including slow ones (116 passed). Each fix has a new test.

🤖 Generated with Claude Code

ryan-kipawa and others added 2 commits October 5, 2026 13:04
It flagged identifiers and domain terms as misspellings, turning docs CI red
for non-issues. great-docs lint still runs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- create(overwrite=True) validates arguments before deleting (#140)
- to_sql escapes single quotes and maps bools to 1/0; by_muid(str) uses it (#144)
- Tool progress handlers attach before running; slope warnings surface (#145)
- Alternative.scenarios and __eq__ walk scenarios by tree and compare group (#142)
- run() raises RuntimeError on non-zero exit or missing results (#143)
- Scenario iteration/find_by_name handle duplicate names, AlternativeGroup
  iterates the whole tree, TopoRepairTool raises on unsupported models,
  close() always returns None, dead .mupp check removed (#146)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

📚 Preview this PR's docs locally

Fetch the just-built site and open it in your browser:

# this exact build
great-docs preview --run 37310118691

# or always the latest build for this PR
great-docs preview --pr 149
Auth & tips
  • Requires great-docs: pip install great-docs (or run via pipx/uvx).
  • Auth: run gh auth login then add --use-gh, or set GITHUB_TOKEN (needs Actions: read).
  • Jump to a page: add --path reference/index.html.
  • Latest vs exact: --pr <n> grabs the newest build; --run <id> pins this one.
  • Re-download: --refresh ignores the local cache.

Reverts c5a1a12. The words it flagged are .NET and MIKE+ identifiers, so they
go in docs/dictionary.txt, which Harper reads in order: an uppercase entry must
come before its lowercase twin. Also fixes the prose findings (a missing comma,
a mass-noun slip, '50 m.' written out) and rewords two comments and a doctest
whose apostrophes the spell check can't take.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ryan-kipawa ryan-kipawa changed the title Fix #140, #142, #143, #144, #145, #146; drop Harper proofread Fix #140, #142, #143, #144, #145, #146 Oct 5, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ryan-kipawa
ryan-kipawa merged commit e308631 into main Oct 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment