Skip to content

Dfs0.read() duplicates the item-selection logic of the other dfs readers #1029

Description

@ecomodeller

Dfs0.read re-implements the _valid_item_numbers / item-info slicing sequence that _Dfs123 performs for dfs1/2/3. The duplication is why Dfs0.read() has drifted from the others in signature (it has no keepdims).

Extracting the shared step is a prerequisite for enforcing one read signature across the readers.


Code sites:

  • src/mikeio/dfs/_dfs0.py (Dfs0.read)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions