feat(compliance): show preferred phone-call time in the call queue - #1449
Draft
Blume1977 wants to merge 1 commit into
Draft
feat(compliance): show preferred phone-call time in the call queue#1449Blume1977 wants to merge 1 commit into
Blume1977 wants to merge 1 commit into
Conversation
The customer's preferred phone-call time was only visible in the call-queue detail view. Compliance staff calling through a phone queue could not see it in the overview and had to open each entry. A new "Anrufzeiten" column is shown at the end of the call-queue list, only in the two queues where a call is scheduled from the customer's own phone details: ManualCheckPhone and ManualCheckIpCountryPhone. The value is the raw, semicolon-separated time slots the customer selected; an empty value shows "-". The value is delivered by the API on CallQueueItem. Until @dfx.swiss/core carries the field (DFXswiss/packages#180), a small typings bridge exposes phoneCallTimes on CallQueueItem so the screen reads it type-safely; the bridge can be removed once core publishes the field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was
Neue Spalte «Anrufzeiten» am Ende der Call-Queue-Übersicht, nur in den zwei Telefon-Queues ManualCheckPhone und ManualCheckIpCountryPhone (die IP-Liste
ManualCheckIpPhonebewusst ohne Spalte, so entschieden). Zeigt die vom Kunden gewählte bevorzugte Anrufzeit als Rohwert (semikolon-getrennte Slots, z.B.H9To10;H10To11); Leerwert →-.Warum
Die Anrufzeit war bisher nur in der Detailansicht sichtbar. Beim Abtelefonieren einer Telefon-Queue musste Compliance jeden Eintrag einzeln öffnen. Die Spalte in der Übersicht spart diesen Schritt.
Wie
compliance-call-queue.screen.tsx:showPhoneCallTimes-Flag (zwei Queues), Header- und Zellen-Spalte,columnCountangepasst; gleiches Muster wie die bestehenden SpaltenshowIp/showCountry/showStatus.Phone Call Timesin DE/FR/IT (Anrufzeiten / Heures d'appel / Orari di chiamata).CallQueueItem.phoneCallTimes. Bis@dfx.swiss/coredas Feld trägt (feat(core): add phoneCallTimes to CallQueueItem packages#180), stellt eine kleine, klar dokumentierte Typ-Brücke intypings/das Feld type-sicher bereit (idiomatisch wietypings/bitbox-webhid.d.ts). Die Brücke kann entfernt werden, sobald core das Feld published.Abhängigkeit für echte Werte
Die Spalte rendert eigenständig (leer →
-). Echte Werte erscheinen, sobald der API-Teil (DFXswiss/backend#3924, fülltphoneCallTimesim CallQueueItem-DTO) live ist. Reihenfolge unkritisch, da das Feld optional ist.Tests
compliance-call-queue-detail.screen+call-queue-outcome-form: 42 Tests grün.--max-warnings 0); tsc auf den geänderten Dateien ohne Fehler; i18n-Keys in DE/FR/IT konsistent.