01a04757 - Drop the leftover UserData account-wallet field by TaprootFreakAI · Pull Request #1439 · DFXswiss/app

TaprootFreakAI · 2026-08-28T20:39:06Z

EN:
This PR removes the leftover UserData account-wallet from the support UI. The call-queue Wallet row shows only the per-user walletName. The user-data panel no longer has an account-wallet row. That matches the backend, which no longer stores a wallet on the KYC account.

DE:
Dieser PR entfernt die übrig gebliebene Account-Wallet aus der Support-UI. Die Wallet-Zeile in der Call-Queue zeigt nur noch den per-user walletName. Das User-Data-Panel hat keine Account-Wallet-Zeile mehr. Das entspricht dem Backend, das auf dem KYC-Konto keine Wallet mehr speichert.

Details

UserDataDetail.wallet mirrored UserData.wallet on the API. That column is dropped. Per-user walletName remains on the users tab.

Coverage deviation

CONTRIBUTING coverage is a review gate, not CI. This PR does not bring these presentational files to 100% (change is deleting an unused field / the account-wallet row):

src/hooks/compliance.hook.ts — type-only delete of UserDataDetail.wallet
src/components/compliance/call-queue/call-queue-user-info.tsx — presentational; existing tests mock CallQueueUserInfo
src/components/compliance/user-data-panel.tsx — presentational row removal

Per-file 100% is not claimed. The numbers belong in a follow-up that instruments these files; this PR does not raise them to the ratchet.

Playwright

Playwright visual tests do not run in CI. The committed overview baseline already has no account-wallet row. Regenerating platform-specific goldens is out of scope.

Reality

The expired-otp full-stack case SQL-writes account_merge.expiration. Declared in docs/test-architecture.md.

Related: DFXswiss/backend#5270.

The support call-queue shows the per-user walletName only. The account wallet on UserDataDetail is gone with the backend column.

github-actions · 2026-08-28T20:44:35Z

🤖 PR Review Bot

❌ TypeScript: 1 errors

_{This is an automated review. Please address the issues above.}

UserData no longer has a wallet. The per-user wallet stays on the users tab.

TaprootFreakAI · 2026-08-28T23:33:58Z

The TypeScript error was UserDataDetail.wallet in the user-data panel. That row is gone in a98abae; Build and test at this head is green.

TaprootFreakAI · 2026-08-28T23:33:59Z

EN:
Ready after 4 review passes.
This PR removes the leftover UserData account-wallet from the support UI and covers the DFX account-merge screen, including the merge-mail URL on a default DFX account.

DE:
Bereit nach 4 Review-Durchläufen.
Dieser PR entfernt die übrig gebliebene Account-Wallet aus der Support-UI und deckt die DFX-Zusammenlegen-Seite ab, inklusive Merge-Mail-URL auf einem normalen DFX-Konto.

Details

Head af1b4b1853d901e7883224960f3f2c0a7848a15b (verified). mergeable: MERGEABLE.

CI on this head: Build and test, Full-stack E2E, review, CodeQL — success. Handbook smoke skipped (draft policy).

Grok quality + logic: 0 findings.
Codex logic: 0 findings (one low on E2E_FRONTEND_URL vs SERVICES_URL rejected — default stack both http://frontend).
Codex quality: 3 coverage/golden findings on the original presentational files — rejected. Deviation is declared in the PR body. Grok accepted it. This increment is merge e2e.

RealUnit / Denario / mixed host-matrix cases are test.skip until DFXswiss/backend#5270 is on develop (e2e-stack builds the API from develop). Declared in docs/test-architecture.md.

The DFX services account-merge screen already handles these API outcomes; the full-stack suite now opens each one against Postgres.

The expired-otp case updates account_merge.expiration directly. Record that in the reality declaration and assert the expired error copy.

An unauthenticated /account-merge hop through /kyc then /login. Wait for the mail field before filling on the completed and expired setups.

Read the AccountMergeRequest notification after the product mail-change path. Unanimous RealUnit links to realunit.app; Denario and mixed addresses stay on the DFX host. The confirmation API still works on /account-merge.

CreateUserResult.mail is optional. The merge helper now uses the harness required() helper so tsc --noEmit in the e2e-stack job passes.

Denario may be absent from the loc seed. The merge-mail cases now insert any missing named wallet the same way they already did for RealUnit.

Every merge-mail case now asserts the notification URL contains the merge code. Partner wallets are resolved before createUser so a late insert cannot outrank seed rows during the same file.

Assert pathname, otp query param, and hostname so a decoy ?otp=wrong&next=<code> or evilrealunit.app cannot pass.

DFX-host cases now compare URL.origin to E2E_FRONTEND_URL. Reality declaration notes that a partner-wallet insert is not the seed path.

Hostname alone would accept http://realunit.app. Match the backend contract: https://realunit.app or https://dev.realunit.app.

The stack builds the API from DFXswiss/backend@develop, which still brands merge from the default wallet. Keep the DFX mail-URL assert.

fix(compliance): drop the leftover UserData account-wallet field

31bb72e

The support call-queue shows the per-user walletName only. The account wallet on UserDataDetail is gone with the backend column.

TaprootFreakAI added the ci:full Force the full test and e2e suites on this PR label Aug 28, 2026

fix(compliance): drop the account-wallet row from the user-data panel

a98abae

UserData no longer has a wallet. The per-user wallet stays on the users tab.

TaprootFreakAI marked this pull request as ready for review August 28, 2026 23:34

TaprootFreakAI requested review from TaprootFreak and davidleomay as code owners August 28, 2026 23:34

TaprootFreakAI marked this pull request as draft August 29, 2026 12:37

TaprootFreakAI added 3 commits August 29, 2026 14:45

test(e2e): cover missing, expired and already-completed merge links

09d3cdc

The DFX services account-merge screen already handles these API outcomes; the full-stack suite now opens each one against Postgres.

test(e2e): declare the merge-expiration SQL write

2f8ae2c

The expired-otp case updates account_merge.expiration directly. Record that in the reality declaration and assert the expired error copy.

test(e2e): assert guest merge without otp ends on login

e5afc1a

An unauthenticated /account-merge hop through /kyc then /login. Wait for the mail field before filling on the completed and expired setups.

TaprootFreakAI marked this pull request as ready for review August 29, 2026 15:19

TaprootFreakAI marked this pull request as draft August 29, 2026 16:13

TaprootFreakAI added 8 commits August 29, 2026 18:16

test(e2e): require master.mail before filling the merge form

60f6d74

CreateUserResult.mail is optional. The merge helper now uses the harness required() helper so tsc --noEmit in the e2e-stack job passes.

test(e2e): insert a missing partner wallet instead of failing loud

0404655

Denario may be absent from the loc seed. The merge-mail cases now insert any missing named wallet the same way they already did for RealUnit.

test(e2e): pin merge-mail URLs to the otp and look up wallets first

73aaa6e

Every merge-mail case now asserts the notification URL contains the merge code. Partner wallets are resolved before createUser so a late insert cannot outrank seed rows during the same file.

test(e2e): parse merge-mail URLs instead of matching substrings

866fe6a

Assert pathname, otp query param, and hostname so a decoy ?otp=wrong&next=<code> or evilrealunit.app cannot pass.

test(e2e): pin DFX merge-mail origin to the harness frontend

fa8bb86

DFX-host cases now compare URL.origin to E2E_FRONTEND_URL. Reality declaration notes that a partner-wallet insert is not the seed path.

test(e2e): pin RealUnit merge-mail origin to https hosts

21e1731

Hostname alone would accept http://realunit.app. Match the backend contract: https://realunit.app or https://dev.realunit.app.

test(e2e): skip merge-host matrix until backend#5270 is on develop

af1b4b1

The stack builds the API from DFXswiss/backend@develop, which still brands merge from the default wallet. Keep the DFX mail-URL assert.

TaprootFreakAI marked this pull request as ready for review August 29, 2026 19:46

TaprootFreakAI marked this pull request as draft September 2, 2026 10:00

Navigation Menu

Uh oh!

01a04757 - Drop the leftover UserData account-wallet field - #1439

01a04757 - Drop the leftover UserData account-wallet field#1439
TaprootFreakAI wants to merge 13 commits into
developfrom
01a04757-drop-account-wallet-support-dto

TaprootFreakAI commented Aug 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 28, 2026

Uh oh!

TaprootFreakAI commented Aug 28, 2026

Uh oh!

TaprootFreakAI commented Aug 28, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

TaprootFreakAI commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage deviation

Playwright

Reality

Uh oh!

github-actions Bot commented Aug 28, 2026

🤖 PR Review Bot

❌ TypeScript: 1 errors

Uh oh!

TaprootFreakAI commented Aug 28, 2026

Uh oh!

TaprootFreakAI commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

TaprootFreakAI commented Aug 28, 2026 •

edited

Loading

TaprootFreakAI commented Aug 28, 2026 •

edited

Loading