0a974e89 - Set FAUCET_LOW_BALANCE_THRESHOLD in the e2e-stack API env - #1431
Draft
Danswar wants to merge 1 commit into
Draft
0a974e89 - Set FAUCET_LOW_BALANCE_THRESHOLD in the e2e-stack API env#1431Danswar wants to merge 1 commit into
Danswar wants to merge 1 commit into
Conversation
The API validates FAUCET_LOW_BALANCE_THRESHOLD in its Configuration constructor and throws when it is unset, which kills the whole boot rather than only the faucet feature. Since that guard landed, the api service crash-loops and up.sh times out after 540s waiting for it to become healthy, so no Playwright test runs at all. The value is a tuning threshold, not a credential; the faucet wallet is not funded in this stack, so any positive value works - 0.05 matches the neighbouring REALUNIT_W2W_GAS_LOW_BALANCE_THRESHOLD, which exists for the identical guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
The API container in
e2e-stackno longer boots: itsConfigurationconstructor validatesFAUCET_LOW_BALANCE_THRESHOLDand throws when it is unset, so the process exits before Nest starts andup.shtimes out after 540s waiting forapito be healthy.env/api.envnever set that variable, so every full E2E run since that guard landed fails before a single Playwright test executes. This adds the variable next to the identicalREALUNIT_W2W_GAS_LOW_BALANCE_THRESHOLDentry.DE:
Der API-Container in
e2e-stackbootet nicht mehr: SeinConfiguration-Konstruktor validiertFAUCET_LOW_BALANCE_THRESHOLDund wirft, wenn die Variable fehlt, wodurch der Prozess vor dem Nest-Start abbricht undup.shnach 540s auf einen gesundenapiwartet.env/api.envhat diese Variable nie gesetzt, also scheitert seither jeder vollständige E2E-Lauf, bevor überhaupt ein Playwright-Test läuft. Dieser PR ergänzt die Variable direkt neben dem gleichartigen EintragREALUNIT_W2W_GAS_LOW_BALANCE_THRESHOLD.Details
Observed failure
up.shwaits for theapiservice and then dumps the container log:The throw happens while a module-level static initializer builds the config, i.e. during
require, so it is fatal for the process — the faucet feature itself is never reached.Timeline
The last green full E2E run was at 2026-08-26T09:57Z. The guard was merged into the API at
10:45Z. Every full run after that point fails with the log above; none of them reach the
Playwright step.
Why this value
It is a tuning threshold in ETH, not a credential, and the guard only requires a finite value
greater than zero. No faucet wallet is funded in this hermetic stack, so the threshold is never
compared against a real balance.
0.05mirrorsREALUNIT_W2W_GAS_LOW_BALANCE_THRESHOLD, whichsits in the same block for the identical kind of guard, and matches the API's own
.env.example.Scope
One variable plus a comment covering both threshold entries. No compose or script change.