Skip to content

Pin the buy e2e locale so the collection-IBAN test stops depending on account data #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuakrueger-dfx wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Pin the buy e2e locale so the collection-IBAN test stops depending on account data #1269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion e2e/buy-process.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,11 @@ test.describe('Buy Process - UI Flow', () => {

// asset-out is pinned: without it the screen picks the first listed asset, which has
// no price rule in the local seed and the quote never reaches the payment details.
// lang=en pins the UI locale: the selectors and the baselines below are English, and without
// the parameter the language comes from the test account's stored user.language, which anyone
// can change on the server and which makes this test fail with "element(s) not found".
await page.goto(
`/buy?session=${token}&blockchain=Ethereum&asset-in=EUR&asset-out=ETH&amount-in=100&personal-iban=frick`,
`/buy?session=${token}&blockchain=Ethereum&asset-in=EUR&asset-out=ETH&amount-in=100&personal-iban=frick&lang=en`,
);

const paymentDetails = page
Expand Down
Loading