Skip to content

refactor: use the SDK recommendation client #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TaprootFreak wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

refactor: use the SDK recommendation client #1240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/account/recommendations-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@
import { useSettingsContext } from 'src/contexts/settings.context';
import { useWindowContext } from 'src/contexts/window.context';
import {
CreateRecommendation,

Check failure on line 22 in src/components/account/recommendations-section.tsx

View workflow job for this annotation

GitHub Actions / review 

Module '"@dfx.swiss/react"' has no exported member 'CreateRecommendation'.
Recommendation,

Check failure on line 23 in src/components/account/recommendations-section.tsx

View workflow job for this annotation

GitHub Actions / review 

Module '"@dfx.swiss/react"' has no exported member 'Recommendation'.
RecommendationStatus,

Check failure on line 24 in src/components/account/recommendations-section.tsx

View workflow job for this annotation

GitHub Actions / review 

Module '"@dfx.swiss/react"' has no exported member 'RecommendationStatus'.
RecommendationType,

Check failure on line 25 in src/components/account/recommendations-section.tsx

View workflow job for this annotation

GitHub Actions / review 

Module '"@dfx.swiss/react"' has no exported member 'RecommendationType'.
} from 'src/dto/recommendation.dto';
import useRecommendation from 'src/hooks/recommendation.hook';
useRecommendation,

Check failure on line 26 in src/components/account/recommendations-section.tsx

View workflow job for this annotation

GitHub Actions / review 

Module '"@dfx.swiss/react"' has no exported member 'useRecommendation'.
} from '@dfx.swiss/react';
import { blankedAddress, formatSwissDate, partition, url } from 'src/util/utils';

interface RecommendationFormData {
Expand Down Expand Up @@ -78,7 +78,7 @@

async function loadRecommendations(): Promise<void> {
return getRecommendations()
.then((r) => setRecommendations(r.sort((a, b) => b.id - a.id)))

Check failure on line 81 in src/components/account/recommendations-section.tsx

View workflow job for this annotation

GitHub Actions / review 

Parameter 'b' implicitly has an 'any' type.

Check failure on line 81 in src/components/account/recommendations-section.tsx

View workflow job for this annotation

GitHub Actions / review 

Parameter 'a' implicitly has an 'any' type.

Check failure on line 81 in src/components/account/recommendations-section.tsx

View workflow job for this annotation

GitHub Actions / review 

Parameter 'r' implicitly has an 'any' type.
.catch(() => {
// ignore errors
});
Expand Down Expand Up @@ -116,7 +116,7 @@

const action = confirm ? confirmRecommendation : rejectRecommendation;

action(recommendation)
action(recommendation.id)
.then(() => loadRecommendations())
.catch((error: ApiError) => setRecommendationError(error.message ?? 'Unknown error'))
.finally(() => {
Expand Down
35 changes: 0 additions & 35 deletions src/dto/recommendation.dto.ts
View file
Open in desktop

This file was deleted.

48 changes: 0 additions & 48 deletions src/hooks/recommendation.hook.ts
View file
Open in desktop

This file was deleted.

Loading