refactor: use the SDK personal IBAN contract - #1239
Draft
TaprootFreak wants to merge 1 commit into
Draft
Conversation
🤖 PR Review Bot❌ TypeScript: 8 errorsThis is an automated review. Please address the issues above. |
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumer side of step 1 of DFXswiss/packages#198: use the personal IBAN contract from
@dfx.swiss/reactand drop the local copies.Depends on DFXswiss/packages#199.
Changes
src/dto/virtual-iban.dto.tsandsrc/hooks/virtual-iban.hook.tsare gone;VirtualIbananduseVirtualIbannow come from the package.normalizePersonalIban,toPersonalIbanProviderRequest,isUnrecognizedPersonalIbanSelector) are gone fromsrc/util/personal-iban.tsand are importedfrom the package instead.
isExplicitFrickPersonalIbanRequeststays local and is now built on thepackage's
toPersonalIbanProvider.applicability rule, the response check against a specific bank and account holder, and the URL and
widget parameter handling.
@dfx.swiss/reactwith a hand-written object need the four selectorhelpers in that object.
src/test-utils/personal-iban-sdk-mock.tsholds them once instead ofrestating them in each of the five affected suites.
implementation, in the package.
Before this can go green
The package pin in
package.jsonstill points at the published@dfx.swiss/react, which does notexport
useVirtualIban,VirtualIbanor the selector helpers yet. CI stays red untilDFXswiss/packages#199 is merged and published and the pin is raised here. That is the only thing
missing — verified locally against a build of that branch:
tscclean,npm run lintclean, andthe full suite at 667 passing with no new failures (the two suites failing on
developtoday stillfail, unchanged).