Skip to content

refactor: use the SDK personal IBAN contract - #1239

Draft
TaprootFreak wants to merge 1 commit into
developfrom
feat/use-packages-personal-iban
Draft

refactor: use the SDK personal IBAN contract#1239
TaprootFreak wants to merge 1 commit into
developfrom
feat/use-packages-personal-iban

Conversation

@TaprootFreak

Copy link
Copy Markdown
Contributor

Consumer side of step 1 of DFXswiss/packages#198: use the personal IBAN contract from
@dfx.swiss/react and drop the local copies.

Depends on DFXswiss/packages#199.

Changes

  • src/dto/virtual-iban.dto.ts and src/hooks/virtual-iban.hook.ts are gone; VirtualIban and
    useVirtualIban now come from the package.
  • The generic selector helpers (normalizePersonalIban, toPersonalIbanProviderRequest,
    isUnrecognizedPersonalIbanSelector) are gone from src/util/personal-iban.ts and are imported
    from the package instead. isExplicitFrickPersonalIbanRequest stays local and is now built on the
    package's toPersonalIbanProvider.
  • The feature-specific parts stay where they are: error copy, the currency/payment-method
    applicability rule, the response check against a specific bank and account holder, and the URL and
    widget parameter handling.
  • The suites that replace @dfx.swiss/react with a hand-written object need the four selector
    helpers in that object. src/test-utils/personal-iban-sdk-mock.ts holds them once instead of
    restating them in each of the five affected suites.
  • The selector tests that only exercised those helpers are dropped here — they now live with the
    implementation, in the package.

Before this can go green

The package pin in package.json still points at the published @dfx.swiss/react, which does not
export useVirtualIban, VirtualIban or the selector helpers yet. CI stays red until
DFXswiss/packages#199 is merged and published and the pin is raised here.
That is the only thing
missing — verified locally against a build of that branch: tsc clean, npm run lint clean, and
the full suite at 667 passing with no new failures (the two suites failing on develop today still
fail, unchanged).

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

🤖 PR Review Bot

❌ TypeScript: 8 errors


This is an automated review. Please address the issues above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant