9559e7d4 - Build the error-fix fixer: drive an error.fix conclusion to a draft PR unattended - #56

Draft

Danswar wants to merge 114 commits into

9559e7d4-error-fix-fixer

Commits on Sep 2, 2026

9559e7d4 - Build the error-fix fixer: drive an error.fix conclusion to a draft PR unattended

Danswar
and
claude
committed
94731a5
Fix the review-prompt gap and 9 rounds of cross-vendor review findings.

Danswar
and
claude
committed
dac389c
Fix the origin_seq ordering race across three rounds of review.

Danswar
and
claude
committed
3bceac9
Fix the grok-pr gate findings from the first formal review pass.

Danswar
and
claude
committed
2ae2e68
Close the remaining gaps from the first two formal gate rounds.

Danswar
and
claude
committed
37e2a7e
Add a branch-identity check before the unattended first push.

Danswar
and
claude
committed
1929643
Close the error_id normalization gap across write and read paths.

Danswar
and
claude
committed
2c95c18
Normalize the remaining raw error_id comparison sites.

Danswar
and
claude
committed
8dbadcb
Restore fail-closed push behavior for ordinary tasks.

Danswar
and
claude
committed
8848d0c
Gate the push shortcut on error_fix_confirmed, not bare error_id.

Danswar
and
claude
committed
cd5fe9a
Fail the task on empty-review-diff instead of looping forever

Danswar
and
claude
committed
1ab2cad
Distinguish transient git-probe failure from a genuinely empty review diff

Danswar
and
claude
committed
e191878
Close two gaps in the transient-vs-empty diff distinction, fence briefs too.

Danswar
and
claude
committed
c0c8901
Give the auto-generated German summary a real German sentence.

Danswar
and
claude
committed
0360db1
Fix a stale function reference and unfinished comment.

Danswar
and
claude
committed
a10647f
Stop the driver's control file from leaking into the pushed worktree.

Danswar
and
claude
committed
2594983
Pin the push-destination check to github.com and decouple PR-number backfill.

Danswar
and
claude
committed
4828b3a
Replace parse-then-validate with a strict allowlist for push destinations.

Danswar
and
claude
committed
085f28f
Fail closed when an error-fix task's repo can't be resolved for the push check.

Danswar
and
claude
committed
12e333d
Make push_branch and PR-matching enforce their own invariants, not the caller's.

Danswar
and
claude
committed
fccb775
Fix the third place round 42's payload-first repo resolution missed.

Danswar
and
claude
committed
4d41347

Commits on Sep 3, 2026

Dispatch same-vendor PR-review dimensions in parallel, as CONTRIBUTING.md requires.

Danswar
and
claude
committed
f32d303
Stop recording each PR-review dimension from discarding a sibling's result.

Danswar
and
claude
committed
5f5a6dc
Finish recording every dimension before a launch-phase exception propagates.

Danswar
and
claude
committed
8823980
Fix a comment that misdescribed _first_sentence's punctuation handling.

Danswar
and
claude
committed
5b5abfd
Stop _drive_one from acting on error-fix tasks whose session closed.

Danswar
and
claude
committed
40ffb29
Guard retry-phase exceptions in _drive_parallel_pr_pair's finish loop too.

Danswar
and
claude
committed
fe5a190
Enforce a deadline on the vendor CLI subprocess in lane.py.

Danswar
and
claude
committed
b01fa07
Strip service/environment in fingerprint() to match consumer normalization.

Danswar
and
claude
committed
d8539d2
Type ExecArgv as a Protocol instead of Callable[..., Any].

Danswar
and
claude
committed
160a4e2
Replace preexec_fn with start_new_session in the vendor CLI runner.

Danswar
and
claude
committed
9794935
Thread the resolved checkout base through review diffing and PR-open.

Danswar
and
claude
committed
e0b6337
Re-prefix the bare PR base before healing task.ref from it.

Danswar
and
claude
committed
c393b10
Detect an already-prefixed PR base by prefix, not by slash presence.

Danswar
and
claude
committed
06ef0b5
Accept the new base_ref keyword in the parallel-pair test's fake build stub.

Danswar
and
claude
committed
b4c5c7a
Normalize stored fingerprints before comparison at all five sites.

Danswar
and
claude
committed
34b62c1
Strip origin/ prefix at the gh pr create boundary and simplify heal.

Danswar
and
claude
committed
dcb861e
Retry kill and wait once more if the post-SIGKILL reap also times out.

Danswar
and
claude
committed
2b97356
Strip error_class and stack_sig whitespace in fingerprint construction.
Danswar
committed
b30736f
Fail closed when an explicit review base_ref does not resolve locally.
Danswar
committed
162cab0
Send vendor-appropriate tool instructions in PR-review spec prompts.
Danswar
committed
c1fc86c
Give local_check_pass its own longer, configurable timeout.
Danswar
committed
00d876a
Accept the new vendor keyword in the parallel-pair test's fake build stub.

Danswar
and
claude
committed
09c9c23
Re-resolve the created PR's actual base from GitHub instead of the requested one.

Danswar
and
claude
committed
7257870
Kill the whole process group when a check command times out.

Danswar
and
claude
committed
4013f45
Drop unused local_check_timeout_sec import in fixer_act.py.

Danswar
and
claude
committed
9d100ec
Fix stale comment claiming this PR does not touch errors.py.

Danswar
and
claude
committed
6c08b66
Reword the shared review-diff line to be vendor-neutral.

Danswar
and
claude
committed
aa640ef
Fail closed on a stale local_check_pass before pushing.

Danswar
and
claude
committed
5ce2bd7
Retry base resolution instead of freezing an unverified fallback.

Danswar
and
claude
committed
8b50119
Share the second kill+wait tier between runtime and lane.

Danswar
and
claude
committed
4613ab9
Drop the dead signal import and align a fake HEAD sha with its push mock.

Danswar
and
claude
committed
677efad
Close the unbound-checked-sha loophole in the push freshness gate.

Danswar
and
claude
committed
e383b5d
Retry the resume-path gh pr view call on a transient failure too.

Danswar
and
claude
committed
d36eb5d
Give the push-time SHA-freshness gate real git repos and consistent test shas.

Danswar
and
claude
committed
85e1f95
Restore two round-59 regression tests deleted by an earlier mistake.

Danswar
and
claude
committed
343411f
Unify gh failure classification in github_act.py's pr.open resume path.

Danswar
and
claude
committed
c49b5cb
Fix grok-pr round 31 findings: misleading pr.open status, origin/-only base, stale comment, bare asserts, bare dict annotation.

Danswar
and
claude
committed
b18b046
Expect two scan_github calls for a stable pending pr.open message.

Danswar
and
claude
committed
e1d8fd7
Report the recorded PR number when an error-status pr.open still carries one.

Danswar
and
claude
committed
da90bd4
Drop the orphaned pending-only PR-number lookup helper.

Danswar
and
claude
committed
7220653
Re-pend error-status pr.open rows with a recorded number before resuming, and use a status-neutral pending-retry message.

Danswar
and
claude
committed
8888a0c
Pin the exact pending-retry wording instead of an ambiguous substring.

Danswar
and
claude
committed
e222131
Check error-with-number pr.open rows before bare-pending ones in the fixer driver.

Danswar
and
claude
committed
992486c
Update the pushed-to-pr.open docstring and DESIGN.md to the current three-way contract.

Danswar
and
claude
committed
9e7d5a6
Fix 6 test-quality findings: exact counts, split OR-asserts, drop tautological/dead assertions, avoid sleep-based ordering, dedupe test helpers.

Danswar
and
claude
committed
cbc1f08
Fix 4 test-quality findings: parametrize expected_repo URL matrix, drop dead import and tautological assertion, dedupe _store helper.

Danswar
and
claude
committed
8800d6f
Drop the unused drive-until-stable result binding.

Danswar
and
claude
committed
48783f1
Pin push_branch to the freshness-gate-verified SHA, not mutable HEAD.

Danswar
and
claude
committed
63041ef
Fix gh failure classification and resume-path PR identity checks.

Danswar
and
claude
committed
d9392aa
Preflight-check the round cap before driving an error-fix task.

Danswar
and
claude
committed
ff64fbe
Fix round-cap off-by-one and 5 review-gate quality findings.

Danswar
and
claude
committed
609e736
Rename the past-cap test correctly and pass base_ref/vendor through the review-spec fake.

Danswar
and
claude
committed
9e86d7e
Rename a test to match what it actually asserts.

Danswar
and
claude
committed
43969fe
Block a duplicate draft when an error-status pr.open row still has a PR number.

Danswar
and
claude
committed
bc995de
Check gh exit code 4 before text heuristics in _classify_gh_failure.

Danswar
and
claude
committed
d9c2752
Bound gh calls in the error-fix-work driver with a timeout.

Danswar
and
claude
committed
862c01c
Add a control-case assertion, a blank line, and drop a redundant import.
Danswar
committed
e905487
Serialize scan_github with a device-wide exclusive lock to close a cross-process race.
Danswar
committed
7d678c8
Strip credential-shaped env vars from the local-check subprocess and redact them from persisted output.
Danswar
committed
2a87f71
Retry a reviewer lane instead of auto-passing when GAPS discloses real coverage gaps.
Danswar
committed
9b7f282
Redact secrets from local-check output before truncating it.
Danswar
committed
d355381
Close GAPS-disqualification bypass: count and scan every GAPS: header, not just the first.
Danswar
committed
a9ca352
Document GAPS-disqualification in README and DESIGN §21.7.
Danswar
committed
4df1429
Strengthen credential-redaction test against a vacuous empty-output pass.
Danswar
committed
b943476
Rename thread-lock test to reflect what it actually exercises.
Danswar
committed
5cdf49c
Add GAPS: 0 zero-numeral test case alongside the existing none-token case.
Danswar
committed
ce2cf99
Strip AGENT_ERROR_FIX_*/AGENT_PG_DSN from the vendor-CLI launch env too.
Danswar
committed
af83634
Document the state=failed exception for rejected gates in pr-review/SKILL.md.
Danswar
committed
3fd9134
Dedup PR-number extraction in fixer_act.py via error_fix_act's shared helper.
Danswar
committed
b6b8bb4
Strengthen local-check credential-redaction test and fix two stale test comments.
Danswar
committed
81e0a67
Fix AGENT_PG_DSN credential test breaking open_store() with an invalid DSN.
Danswar
committed
48559a1
Stop the implementer spec from claiming push/PR-open as its own job.
Danswar
committed
e6f4c15
Add a test proving output-redaction independently of env-popping.
Danswar
committed
45122c0
Exercise the cross-process advisory lock with two Store instances.
Danswar
committed
4453e3c
Narrow the implementer spec's git constraint and close a lock-test timing gap.
Danswar
committed
1fd037c
Fire the advisory-lock test's attempting signal at the actual SQL call.
Danswar
committed
a45d058
Bring SKILL.md contracts and the review-work path into documentation sync.
Danswar
committed
91f9980

Commits on Sep 4, 2026