Gauges

[JakeHartnell]

Summary

Rebases the long-dormant gauges-are-cool branch onto current development, drops the cw-orch test-harness migration that PR #875 reverted workspace-wide, and works through the open checklist from #844. Adds a second example adapter and fills in error-path test coverage. 72 tests, all green; fmt + clippy -D warnings clean; release wasm builds for all three contracts.

Status

Inspired by Curve, forked from WyndDAO (Apache-2.0; git history preserved via the LICENSE/NOTICE files in contracts/gauges/). Originally opened as #844 and stalled since 2024 when the workspace drifted out from under it. This PR brings it back to a mergeable state and addresses most of the #844 checklist.

What's in this PR

Rebase + dep drift

• Rebased onto current development (0178cf55d).
• Removed cw-orch from gauge-adapter. PR Revert "Finish cw-orch integration" #875 reverted the workspace-wide cw-orch integration; the gauge-adapter's Use cw-denom and payment utils in gauge adapter #847 migration was the last holdout. Rewrote the gauge-adapter multitest on plain cw_multi_test; kept Use cw-denom and payment utils in gauge adapter #847's
  cw-denom + payment-utils refactors.
• Fixed dao-interface / dao-voting-cw4 / dao-proposal-single API drift in the orchestrator's multitest harness: ModuleInstantiateInfo now requires salt and uses funds: Option<Vec<Coin>>; GroupContract::New gained
  cw4_group_salt; ProposalSingleInstantiateMsg gained delegation_module; dao_interface::msg::InstantiateMsg gained initial_actions.

Audit fixes

• gauge/src/contract.rs:142 — GAUGES.load(...).unwrap() inside the member_changed hook handler's or_insert_with closure could panic on a transient storage error. x/cw-hooks treats hook-callback panics as failures toward an
  auto-unregister threshold, so a single error here could brick further tally updates. Switched to ? propagation via an explicit Entry::Vacant insert.
• gauge/src/contract.rs:971 — selected_set filter callback used o.as_ref().unwrap() and swallowed storage iterator errors. Refactored so errors flow through the filter and propagate via the existing ? in the downstream map.
• gauge/src/contract.rs:585 — resolved the existing TODO ("this doesn't seem very safe... double check permissions here. Why is check option optional?"). Split add_option into a public validated add_option (called by
  ExecuteMsg::AddOption — runs adapter CheckOption + nonzero-voting-power anti-spam) and a private add_adapter_options for the trusted bulk-add path during attach_gauge. The bool parameter was easy to misuse by accident.

Small voting power (#844 checklist)

A user with 1 unit of voting power (e.g. one staked NFT) who splits 50/50 across two options had Uint128 * Decimal truncate to 0 on both options — their vote silently erased. Added ContractError::VoteWeightRoundsToZero { weight, voting_power } and an early-reject in place_votes. Regression test in multitest/voting.rs::small_voting_power_rejects_round_to_zero_split.

Bug found while expanding tests

create_gauge skipped the max_available_percentage < 1.0 validation that update_gauge already enforced — a gauge could be born with an invariant-violating config that no later update could repair. Added the check; covered by
multitest/errors.rs::create_gauge_rejects_max_available_percent_at_one.

Test coverage expansion (#844 checklist)

New contracts/gauges/gauge/src/multitest/errors.rs with 12 error-path tests covering the validation surfaces existing tests didn't exercise: create_gauge rejection cases, place_votes rejection cases (TooMuchVotingWeight,
NoVotingPower, OptionDoesNotExists), GaugeMissing on bogus IDs, EpochNotReached on premature execute, ownership-required ops, and hook-caller auth.

Marketing adapter improvements (#844 checklist)

• New ExecuteMsg::Reject { submission, soft: bool }. Admin-gated per-submission removal. Soft refunds the bond to the original sender; hard forfeits to the community_pool config field. Guards: SubmissionNotFound,
  CannotRejectDefault (prevents rejecting the default community-pool submission). No-op on the bond side if no required_deposit is configured.
• New AdapterQueryMsg::SubmissionsBySender { sender } query. Returns all submissions whose sender matches the given address — useful for "my submissions" views in registration flows.

Second example adapter (#844 checklist)

New contract: contracts/gauges/budget-allocator/ (gauge-budget-allocator). A minimal adapter that distributes a fixed native-token budget proportional to gauge weights. Admin-curated option list, no bond, native-only — meaningfully
simpler than the marketing adapter. Re-uses gauge-adapter's AdapterQueryMsg / response types as the orchestrator-facing surface (depended on with library feature so contract entry-points don't collide). Serves as both a working
second example and a starting point for adapters that need a similar shape (treasury allocation, validator-preference signaling, AMM-incentive routing). 9 tests; 208K release wasm.

Documentation (#844 checklist)

Rewrote all three READMEs with architecture diagrams, lifecycle walk-throughs, full ExecuteMsg / QueryMsg / error tables, storage layout docs, hook-registration requirements, and a "writing your own adapter" guide. Top-level
contracts/gauges/README.md explains the orchestrator + adapter split; each contract's README is reviewable standalone.

Conventions cleanup

• Schema generators moved from src/bin/ to examples/ to match the rest of the dao-contracts workspace; scripts/schema.sh extended with a contracts/gauges/* loop.
• Dropped unused EmptyMsg test struct (caught by clippy -D dead_code).
• Replaced one try_into().unwrap() (usize → u128) with as u128; safe by construction.
• Workspace Cargo.toml: added gauge-orchestrator, gauge-adapter, gauge-budget-allocator entries; kept the contracts/gauges/* workspace-members glob.

What's intentionally NOT in this PR

• Decay (Gauge Contracts #844 bonus item). Votes losing weight over time until re-cast, forcing re-engagement. Design space is open; left for a separate PR.

Test plan

• cargo test -p gauge-adapter -p gauge-orchestrator -p gauge-budget-allocator → 22 + 41 + 9 = 72 tests, all green.
• cargo fmt --all -- --check → clean.
• cargo clippy --all-targets -- -D warnings on the three gauge crates → clean.
• RUSTFLAGS="-C link-arg=-s" cargo build --release --lib --target wasm32-unknown-unknown for each gauge crate → success. Sizes: gauge_adapter.wasm 259K, gauge_orchestrator.wasm 492K, gauge_budget_allocator.wasm 208K.
• Schema regeneration via scripts/schema.sh → checked-in schema/*.json files updated for all three contracts.

[codecov]

Codecov Report

❌ Patch coverage is 98.11462% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.05%. Comparing base (0178cf5) to head (d2da47e).

Files with missing lines	Patch %	Lines
contracts/gauges/gauge/src/contract.rs	93.84%	51 Missing ⚠️
contracts/gauges/budget-allocator/src/contract.rs	87.06%	15 Missing ⚠️
contracts/gauges/gauge/src/helpers.rs	0.00%	12 Missing ⚠️
contracts/gauges/gauge/src/state.rs	97.85%	10 Missing ⚠️
contracts/gauges/gauge-adapter/src/contract.rs	97.51%	9 Missing ⚠️
contracts/gauges/gauge/src/multitest/hooks.rs	98.83%	3 Missing ⚠️
...gauges/budget-allocator/src/multitest/allocator.rs	99.33%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           development     #928      +/-   ##
===============================================
- Coverage        96.56%   93.05%   -3.51%     
===============================================
  Files              199      178      -21     
  Lines            67407    34131   -33276     
===============================================
- Hits             65094    31762   -33332     
- Misses            2313     2369      +56     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.