Conversation
…p versions to v2.5.0) (DA0-DA0#843)
TODO: 2 tests are failing, because the cw20 cannot be validated with cw-denom. This should be fixed with a cw-orch refactor.
Nightly toolchain is required for integration_tests
Contributor
Author
|
@JakeHartnell ok should have all gauge-orchestrator cw-orch test mirrored |
* fix cargo errors * clarify scalar values a bit more and update comments * added extensions that make math more readable and maintainable
…xpiry (DA0-DA0#862) * fix cargo errors * reorganized fund logic and fixed rewards being lost when funding a previously expired discontinuous linear distribution
* fix cargo errors * validate pre propose submission policy update before reading from storage
* fix cargo errors * remove unnecessary state update
…ate NFT token IDs (DA0-DA0#864) * fix cargo errors * fix ONFT double counting vulnerability
…gration (DA0-DA0#866) * fix cargo errors * validate pre-propose policy on migrate
…tion (DA0-DA0#868) * fix cargo errors * replaced pre-propose submission policy's optional vectors of strings with vectors of addrs * de-dupe redundant code * updated schema
hard-nett
marked this pull request as ready for review
August 12, 2024 15:14
JakeHartnell
changed the base branch from
development
to
feature/cw-orch-interface
August 14, 2024 19:44
| #[cw_serde] | ||
| pub struct InstantiateMsg { | ||
| /// Address that is allowed to return deposits. | ||
| pub admin: String, |
Member
There was a problem hiding this comment.
Maybe let's call this "owner" to differentiate it from the CosmWasm contract admin.
Member
There was a problem hiding this comment.
Let's update this contract to use cw-ownable.
Comment on lines
+50
to
+71
| #[cw_serde] | ||
| #[derive(QueryResponses, cw_orch::QueryFns)] | ||
| pub enum AdapterQueryMsg { | ||
| #[returns(crate::state::Config)] | ||
| Config {}, | ||
| #[returns(AllOptionsResponse)] | ||
| AllOptions {}, | ||
| #[returns(CheckOptionResponse)] | ||
| CheckOption { option: String }, | ||
| #[returns(SampleGaugeMsgsResponse)] | ||
| SampleGaugeMsgs { | ||
| /// Option along with weight. | ||
| /// Sum of all weights should be 1.0 (within rounding error). | ||
| selected: Vec<(String, Decimal)>, | ||
| }, | ||
|
|
||
| // Marketing-gauge specific queries to help on frontend | ||
| #[returns(SubmissionResponse)] | ||
| Submission { address: String }, | ||
| #[returns(AllSubmissionsResponse)] | ||
| AllSubmissions {}, | ||
| } |
Member
There was a problem hiding this comment.
I like adding robust comments for ExecuteMsg and QueryMsg because they basically document the API (and show up in generated docs).
| /// Addres that will call voting power change hooks (often same as voting power contract) | ||
| pub hook_caller: String, | ||
| /// Address that can add new gauges or stop them | ||
| pub owner: String, |
Member
There was a problem hiding this comment.
Let's use cw-ownable for this contract as well.
JakeHartnell
force-pushed
the
feature/cw-orch-interface
branch
from
August 14, 2024 20:51
4c7ffe1 to
3990e13
Compare
Member
|
TODO:
|
JakeHartnell
changed the base branch from
feature/cw-orch-interface
to
gauges-are-cool
August 14, 2024 21:13
Member
|
Closing this as we really should separate Please make a new PR with gauges related work into #844. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds epoch limit for gauge to turn off automatically once reached.
test incoming!