Skip to content

fix(fingerprints): fallback gracefully when browserforge raises ValueError on unsupported Chrome versions #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shdwkl wants to merge 1 commit into from
Closed

fix(fingerprints): fallback gracefully when browserforge raises ValueError on unsupported Chrome versions #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion scrapling/engines/toolbelt/fingerprints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,20 @@ def generate_headers(browser_mode: bool | str = False) -> Dict:
Browser(name="edge", min_version=140),
]
)
return HeaderGenerator(browser=browsers, os=os_name, device="desktop").generate()
try:
return HeaderGenerator(browser=browsers, os=os_name, device="desktop").generate()
except ValueError:
# Fallback if the requested browser version constraint is not present in browserforge's dataset
fallback_browsers = [Browser(name="chrome")]
if not browser_mode:
fallback_browsers.extend(
[
Browser(name="firefox"),
Browser(name="edge"),
]
)
return HeaderGenerator(browser=fallback_browsers, os=os_name, device="desktop").generate()


__default_useragent__ = generate_headers(browser_mode=False).get("User-Agent")