fix: remove dead fetchall() after INSERT and correct retrieve() error message - #377
Merged
Merged
Conversation
fix2015
commented
Jul 15, 2026
fix2015
commented
Contributor
- Remove unnecessary cursor.fetchall() call after INSERT OR REPLACE in storage.py (INSERT returns no rows)
- Fix NotImplementedError message in retrieve() abstract method that incorrectly said 'implement save method'
cursor.fetchall() after an INSERT OR REPLACE statement is a no-op since INSERT does not return any rows. This call is dead code.
Owner
|
I don't know how we left that line there, but thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.