Repository navigation
feat: stream committed match states over WebSockets - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Players and spectators can subscribe to
/v1/matches/{id}/streamfor an initial state and each newly committed turn. A runtime-independent service observer wakes clients after successful commits; durable replay fills notification gaps and periodic reconciliation catches another process writing to the same database.Depends on #12. Streams apply the selected viewer to every state, retain local peer/Host/Origin checks, limit active connections and message sizes, bound writes with timeouts, and close before SQLite during shutdown. Submit moves through REST. This initial protocol sends state frames; event pagination and resume cursors remain separate increments.
Validation: all GitHub Actions checks pass at
0c2f7ec1c17268228b0016050f3fcde09b3c04a3: 43 Rust tests, fmt, clippy, architecture and SQLx metadata checks, cargo-deny, core API compatibility, web checks, and game benchmarks. A real CLI/HTTP/SQLite restart smoke test also passes. New tests cover commit-only notifications, ordered player/spectator streams, other-match isolation, reconnects, invalid upgrades, shutdown, terminal-state delivery before close, and reconciliation after a separate service writes without notification.