Skip to content

fix: AWS VM counts treat terminated instances as running and misclassify Karpenter nodes #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amanfredi wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix: AWS VM counts treat terminated instances as running and misclassify Karpenter nodes #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion AWS/aws_cspm_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,10 @@ class AWSHandle:
"alpha.eksctl.io/nodegroup-type",
"aws:eks:cluster-name",
"eks:nodegroup-name",
# Karpenter-launched nodes carry these instead of the nodegroup tags above
"eks:eks-cluster-name",
"karpenter.sh/nodepool",
"karpenter.sh/provisioner-name",
]

def __init__(
Expand Down Expand Up @@ -855,7 +859,9 @@ def is_vm_kubenode(cls, vm):

@classmethod
def is_vm_running(cls, vm):
return vm["State"]["Name"] != "stopped"
# DescribeInstances keeps terminated instances visible for up to ~1 hour,
# so anything not actively pending/running must not count as running.
return vm["State"]["Name"] in ("pending", "running")

@property
def account_id(self):
Expand Down