Skip to content

fix redstone link transmitter updates neighbor every ticks #10458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HachimiYang wants to merge 1 commit into
base: mc1.21.1/dev
Choose a base branch
from
Open

fix redstone link transmitter updates neighbor every ticks #10458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions src/main/java/com/simibubi/create/content/redstone/link/RedstoneLinkBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,6 @@ public void neighborChanged(BlockState state, Level level, BlockPos pos, Block b
@Override
public void tick(BlockState state, ServerLevel level, BlockPos pos, RandomSource r) {
updateTransmittedSignal(state, level, pos);

if (state.getValue(RECEIVER))
return;
Direction attachedFace = state.getValue(RedstoneLinkBlock.FACING)
.getOpposite();
BlockPos attachedPos = pos.relative(attachedFace);
level.blockUpdated(pos, level.getBlockState(pos)
.getBlock());
level.blockUpdated(attachedPos, level.getBlockState(attachedPos)
.getBlock());
}

@Override
Expand Down Expand Up @@ -172,6 +162,13 @@ public InteractionResult toggleMode(BlockState state, Level level, BlockPos pos)
level.setBlock(pos, state.cycle(RECEIVER)
.setValue(POWERED, blockPowered), Block.UPDATE_ALL);
be.transmit(wasReceiver ? 0 : getPower(level, state, pos));
Direction attachedFace = state.getValue(FACING)
.getOpposite();
BlockPos attachedPos = pos.relative(attachedFace);
level.blockUpdated(pos, level.getBlockState(pos)
.getBlock());
level.blockUpdated(attachedPos, level.getBlockState(attachedPos)
.getBlock());
return InteractionResult.SUCCESS;
});
}
Expand Down
Loading