test(ci): reprove suite-selected mutation fixtures - #1342
Closed
davidfarah2003 wants to merge 5 commits into
Closed
Conversation
A `completionMarker` says "a run of mine that did not finish is not evidence I want counted". These three carried the suite's cell count inside that string, which is a second assertion the suite already makes for itself: each prints `SUITE COMPLETE: <ran> cells` and separately refuses a run whose `ran` is not its EXPECTED_CELLS. The duplicate rotted. A cell was added to the connection-status suite on 2026-08-30 and the fixture still asked for 15, so a finished 18-cell run printed a line the marker could never match and all seven mutants graded INCONCLUSIVE. Nothing failed and the fixture kept reporting; the mutation reproof gate simply stopped grading that file. The other two markers are correct today and rot the same way on the next added cell. All seven connection-status mutants now grade KILLED, transport-liveness 18, transport-liveness-broker 3.
…sal fails Three suites could reach their last cell and still print nothing, so a run that had already reddened the right cell looked like a run that never happened. events-grant-acl had no catch at all. Its later cells feed on earlier ones: a rule that stops refusing lets the spawn through, and the section that parses the refusal then mints on an empty profile and dies inside `mintCreds`, past the finally and before the summary. It now records the throw as a failure and falls through to its own verdict. user-spawn printed its summary only on the success path. The same cascade shape applies: the refusal text is missing, the flags parsed out of it are empty, and the real ledger writer refuses them. The catch prints the summary too. boot-self-heal-gate hung. Two cells expect a successor start to REFUSE and neither stopped one that started anyway, so a live manager with timers and a broker connection held the event loop open and the process never exited. A hang is not a red, so the mutation that caused it graded as no evidence. E1, E9, E11, R1, R2 and the assume-dead mutant were the six that could not be graded. All six now grade KILLED, along with every other mutant in those three fixtures.
The boot-wake-race fixture mutated the redelivery re-announce in connector-core, from a time when that suite's recovery ran through JetStream redelivery. It does not any more. The suite settles each scenario inside a 500ms window chosen so no redelivery can have happened, and its own header says the redelivery guard lives in `smoke:cross-path-dedup` and `smoke:claude-wake`. So the mutation changed nothing the suite observes, the suite passed with it applied, and it graded UNGRADABLE. The re-announce moves to a fixture on cross-path-dedup, which drives both deliveries by hand and reads MeshAgent from source. Two mutants, one per line of the guard, so each is the other's positive control. boot-wake-race keeps a mutation on what it does drive: activation reconciling one buffered wake, with nothing else in the window able to produce a nudge. The mention branch above it stays, so the focus-mention scenario is unaffected. All three grade KILLED.
test(manager,connector-core): make the mutation reproof gate grade what it claims
Contributor
Author
|
Closing this draft proof PR. Its successful changed-set run supplied durable selector evidence for #1341; this branch was never intended to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance-only run for the suite-path mutation selector.
This targets a temporary historical base so the pull-request changed set covers the original fixture-repair range plus the selector correction. It adds no code beyond the existing #1341 head.
The required evidence is the Mutation reproof changed job selecting the historical suite-only fixtures, including the live-only user-spawn cascade, and reaching terminal verdicts. Do not merge this PR. It will be closed after the run is recorded.