This repository was archived by the owner on Jun 5, 2026. It is now read-only.
[Fix] Wrong order when checking the privacy block in the genesis file against stored config - #1138
Closed
ricardolyn wants to merge 1 commit into
Closed
Conversation
…against stored config
ricardolyn
marked this pull request as ready for review
February 17, 2021 19:08
Contributor
Author
|
Merge Consensys-Incorporated/quorum-acceptance-tests#78 after this PR is merged to improve the test stability. |
Contributor
Author
|
Not the right logic after discussion with @nicolae-leonte-go . closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There was an issue with the order when calling
checkAndPrintPrivacyEnhancementsWarninginside theSetupGenesisBlock.This created an issue in the AT
Partial Network upgrade from an old version (q2.5.0/t0.10.5) to privacy enhancements enabled version of geth and tesseraas the test was expecting that message to come before the fatal error.Introduced by #1130.
Changes
checkAndPrintPrivacyEnhancementsWarningcheck