Repository navigation
Revert "fix(deps): update npm dependencies (major) (#1128)" - #1136
Merged
Merged
Conversation
This reverts commit cd587d6. #1128 bumped package.json ranges without updating yarn.lock, so `yarn install --immutable` fails on main. CI stays green only because it caches node_modules keyed on yarn.lock, and any PR that changes the lockfile goes red. Resolving the bumped ranges also breaks the build: - @endo/patterns 2 and @endo/pass-style 2 are incompatible with @endo/exo 1.7.0 (latest), which still depends on @endo/patterns ^1.9.0. Guards built with the new M no longer type-check against makeExo. - @metamask/utils 12 clashes with the utils 11 that @metamask/snaps-execution-environments brings, failing ocap-kernel's build on JsonRpcError. The lockfile is also regenerated for the design-system bump in #1123, which was the only other drift. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ci-belphegor
added
the
no-changelog
rekmarks-consensys-1
enabled auto-merge
October 1, 2026 19:17
Contributor
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Reverts #1128 and regenerates
yarn.lock.#1128 bumped package.json ranges without updating
yarn.lock, soyarn install --immutablefails onmain. CI stays green because it cachesnode_moduleskeyed onyarn.lock. Any PR that changes the lockfile (e.g. by adding a dependency) gets a fresh install and fails.Resolving #1128's ranges also breaks the build, so a lockfile update alone won't fix it:
@endo/patterns2 /@endo/pass-style2 don't work with@endo/exo1.7.0, the latest release, which still depends on@endo/patterns ^1.9.0. Guards built with the newMfail to type-check againstmakeExo(first failure:remote-iterables/src/reader-ref.ts).@metamask/utils12 clashes with the utils 11 copy that@metamask/snaps-execution-environmentsbrings, andocap-kernelfails to build onJsonRpcErrorinVatSupervisor.ts.The lockfile also picks up #1123's design-system bump, the only other drift (16 lines).
Verified locally on a clean install:
yarn install --immutable,yarn build,yarn lint, andyarn test:dev:quietall pass.Renovate will propose these majors again. The
@endopair has to wait for an@endo/exorelease built on patterns 2.References
Checklist
🤖 Generated with Claude Code