fix(webgpu): reject non-Uint8Array byte arguments

[colinaumaty]

Description

Validate JavaScript byte arguments as Uint8Array values before accessing their byteLength property or passing them to js.CopyBytesToGo.

Previously, primitive values could panic in js.Value.Get, while arbitrary objects with a numeric byteLength could reach js.CopyBytesToGo and panic there. These panics could terminate the Go WASM runtime instead of rejecting the promise with the intended expected Uint8Array error.

Fixes #1831

Type of change

• Bug fix (non-breaking change which fixes an issue)

How has this been tested?

• Test A

• Test B

• GOOS=js GOARCH=wasm go test -exec="$(go env GOROOT)/lib/wasm/go_js_wasm_exec" ./backend/accelerated/webgpu/...

• GOOS=js GOARCH=wasm go vet ./backend/accelerated/webgpu/internal/wasmruntime

• GOOS=js GOARCH=wasm golangci-lint run --timeout=5m ./backend/accelerated/webgpu/internal/wasmruntime

A local go test -short ./... run was also attempted. Several unrelated cryptographic test packages reached their existing 10-minute per-package timeout; no failure involved the WebGPU/WASM packages changed here.

How has this been benchmarked?

• Benchmark A, on Macbook pro M1, 32GB RAM
• Benchmark B, on x86 Intel xxx, 16GB RAM

Not benchmarked. The change only adds boundary validation and regression tests.

Checklist:

• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I did not modify files generated from templates
• golangci-lint does not output errors locally
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[ivokub]

Thanks for the PR. Indeed, your point is valid.

Though I don't think we need so many tests to cover this fix. Could you remove the changes from .github/workflows/webgpu.yml and remove backend/accelerated/webgpu/internal/wasmruntime/runtime_test.go alltogether? Even when the tests are correct, then it just adds bloat to source code and CI work.

[colinaumaty]

Thanks for the PR. Indeed, your point is valid.

Though I don't think we need so many tests to cover this fix. Could you remove the changes from .github/workflows/webgpu.yml and remove backend/accelerated/webgpu/internal/wasmruntime/runtime_test.go alltogether? Even when the tests are correct, then it just adds bloat to source code and CI work.

Thanks for the feedback. I removed the WebGPU workflow changes and the runtime test file. The PR now only contains the byte argument validation fix.

@ivokub Please review it again.

[ivokub]

Thanks for the follow-up! Looks good!