Repository navigation
[pull] master from microsoft:master - #186
Merged
Merged
Conversation
* Use flat tree structure for toolbox This improves screen reader output as the toolbox item count is constant. This removes the notion of expanded, since there are no controls to expand or collapse tree items, they are just shown when navigated to. * Add aria-label for toolbox * Align toolbox behaviour with Blockly Remember last selected category when focused. Fix toolbox blur behaviour. Fix bug when returning to the toolbox from the search flyout. * Reinstate extensions by Enter / Space in toolbox This still prevents Enter / Space from toggling the flyout open / closed. * Render led category as uppercase to improve screen reader output This is special casing the namespace as a low effort way to achieve this. Translations already handle this in a better way than English. * Add missing aria-label * Remove comma for "[category], more" label The screen reader output is faster and less ambigious this way * Make ariaLevel optional and remove use where unnecessary * Move sr-only class to react-common CSS * Remove horrible 'led' label special casing Rely on adding block="LED" to namespace in pxt-microbit * Remove ActionAnnouncer.module.scss use --------- Co-authored-by: Richard Knoll <riknoll@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )