Do not call storeChunk upon empty particle species#5667
Merged
psychocoderHPC merged 1 commit intoComputationalRadiationPhysics:devfrom Apr 2, 2026
Merged
Conversation
psychocoderHPC
approved these changes
Apr 2, 2026
psychocoderHPC
merged commit 5996c69
into
ComputationalRadiationPhysics:dev
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5510
Close #5666
In #5510, I added a workaround to ensure that each MPI process performs at least one (possibly empty)
storeChunk()operation per dataset, necessary due to HDF5 2.0. However, empty datasets do not allowstoreChunk()operations at all (even empty ones).So, this PR ensures that the workaround only runs when there is actually data for the dataset.