Explicitly target iOS and macOS to osx and Windows platforms (only)#3186
Open
matt-goldman wants to merge 5 commits intoCommunityToolkit:mainfrom
Open
Explicitly target iOS and macOS to osx and Windows platforms (only)#3186matt-goldman wants to merge 5 commits intoCommunityToolkit:mainfrom
matt-goldman wants to merge 5 commits intoCommunityToolkit:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo-wide MSBuild configuration to avoid including Apple TFMs when building on unsupported host OSes (e.g., Linux), enabling developers to build Android (and optionally Tizen) without requiring iOS/macOS workloads.
Changes:
- Add a conditional
PropertyGroupinDirectory.Build.targetsto overrideTargetFrameworkson non-macOS/non-Windows hosts when iOS is present. - Ensure
Exeprojects only target Android in that scenario, with optional Tizen inclusion.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds MS Build conditions to explicitly exclude macOS and iOS TFMs when the OS is not macOS or Windows.
No tests included as it would require adding a new workflow with a Linux-targetted runner specifically just for this one test. That's probably not necessary; however could be useful in future as would allow building Android (and Tizen) binaries on a Linux runner. Might be worth considering, but for now I did not want to introduce a workflow just for that.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
Just confirming that this is a no-op for any existing users, and just enables development on Linux.