fix camera-preview size issue on iOS (#2296)#2862
fix camera-preview size issue on iOS (#2296)#2862MoienTajik wants to merge 2 commits intoCommunityToolkit:mainfrom
Conversation
|
Thank you for this. I think the better fix is to allow developers to provide this value. Either by an options setting or a property on the CameraView, or both. |
|
Thanks for the review @bijington! To confirm, I’ll add a cross-platform preview-scaling enum on |
|
Sorry I have questions:
|
|
Hello there, is there any chance that we get this fix? |
|
|
Hello again, we have been waiting for this important bug fix for quite some time. |
There was a problem hiding this comment.
Pull request overview
Fixes an iOS/macCatalyst CameraView preview/capture framing mismatch by changing the preview layer scaling mode so the preview is no longer cropped relative to the captured image.
Changes:
- Update iOS/macCatalyst camera preview
VideoGravitytoResizeAspectto avoid aspect-fill cropping and better match captured output.
Description of Change
This PR fixes an issue with
CameraViewwhere the camera preview showed an image of a different size (smaller/larger based on selected resolution) than the one actually captured.PR Checklist
approved(bug) => not approved yetmainat time of PR