Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
using System.ComponentModel;
using Aspire.Hosting.ApplicationModel;
using CommunityToolkit.Aspire.Utils;
#pragma warning disable CS0618 // Type or member is obsolete
using UvicornAppResource = Aspire.Hosting.ApplicationModel.UvicornAppResource;
#pragma warning restore CS0618 // Type or member is obsolete

namespace Aspire.Hosting;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ string IResourceWithDacpac.GetDacpacPath()
var packagePath = packageMetadata.PackagePath;
if (this.TryGetLastAnnotation<DacpacMetadataAnnotation>(out var relativeDacpacMetadata))
{
return Path.Combine(packagePath, relativeDacpacMetadata.DacpacPath);;
return Path.Combine(packagePath, relativeDacpacMetadata.DacpacPath);
}
else
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public void KurrentDBResourceCtorShouldThrowWhenNameIsNull()
var builder = new DistributedApplicationBuilder([]);
const string name = null!;

var action = () => new KurrentDBResource(name);
var action = () => new KurrentDBResource(name!);

var exception = Assert.Throws<ArgumentNullException>(action);
Assert.Equal(nameof(name), exception.ParamName);
Expand Down
1 change: 0 additions & 1 deletion tests/CommunityToolkit.Aspire.Testing/ConformanceTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ protected virtual void DisableRetries(TOptions options) { }
/// <summary>
/// Populates the Configuration with everything that is required by the Component
/// </summary>
/// <param name="configuration"></param>
protected abstract void PopulateConfiguration(ConfigurationManager configuration, string? key = null);

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ public static class TypeScriptAppHostTest
/// <param name="waitStatus">The Aspire resource status to wait for.</param>
/// <param name="requiredCommands">Optional commands that must exist on <c>PATH</c> before validation runs.</param>
/// <param name="secrets">Optional dictionary of secret key-value pairs to set via <c>aspire secret set</c> before starting the app host.</param>
/// <param name="waitTimeoutSeconds">Optional timeout, in seconds, to wait for resources to reach the expected status.</param>
/// <param name="cancellationToken">The cancellation token.</param>
public static async Task Run(
string appHostProject,
Expand Down
Loading