Fix progress text metadata negotiation#13386
Fix progress text metadata negotiation#13386rattus128 wants to merge 1 commit intoComfy-Org:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request introduces a new server feature flag 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @rattus128, why would we use a feature flag for this? |
|
@alexisrolland I believe it's using a feature flag because it's changing an unversioned binary format. Somehow, we need to know whether to send the old version format (which only old clients will be able to parse) or the new version format (which only new clients will be able to parse). While the feature flags system will mostly work here, it does mean that users that are connected to ComfyUI at the time a deployment is rolled out (a common case on Comfy Cloud) may start experiencing parsing errors until they refresh. |
The preview of Get Image Size particulars broke due to FE protocol updates.
Example Test Conditions:
Linux, firefox
Load Image -> Get Image Size -> Preview as Text
Before:
After: