N°9455 - Feature removal - console screen behavior#924
Conversation
|
| Filename | Overview |
|---|---|
| setup/wizardsteps/WizStepLandingBeforeAudit.php | Adds the fast-track state reconstruction, but misses some parameters normally produced by module-choice finalization. |
| setup/wizardsteps/WizStepWelcome.php | Creates the setup token earlier and renders the update-only fast-track form. |
Comments Outside Diff (1)
-
setup/wizardsteps/WizStepLandingBeforeAudit.php, line 24 (link)Symlink flag disabled
On the fast-track form there is no
use_symbolic_linkscheckbox field, soSaveParameter()stores the default fromMFCompiler::UseSymbolicLinks()as a boolean.DataAuditSequencerlater enables symlinks only when the parameter is exactly the string"on", so an existing true symlink setting is silently turned off for the compatibility compile. That makes the fast-track audit compile with copied files instead of the current symlink behavior.
Reviews (1): Last reviewed commit: "Setup fast track (keep current options)" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| if ($this->oWizard->GetParameter('skip_wizard', false)) { | ||
| $oExtensionMap = new iTopExtensionsMap($oRuntimeEnv->GetBuildEnv()); | ||
| $aExtensionsFromDatabase = $oExtensionMap->GetChoicesFromDatabase($oConfig); | ||
| $this->oWizard->SetParameter('selected_extensions', json_encode($aExtensionsFromDatabase)); | ||
| $adModulesFromDatabase = ModuleInstallationRepository::GetInstance()->ReadComputeInstalledModules($oConfig); | ||
| $this->oWizard->SetParameter('selected_modules', json_encode(array_keys($adModulesFromDatabase))); |
There was a problem hiding this comment.
When the fast-track path is used, this branch only restores selected_extensions and selected_modules from the current database. It skips the normal GetAddedAndRemovedExtensions() finalization, so downstream audit and cleanup forms receive removed_extensions as the default empty list. If an installed extension is no longer present or should be treated as removed during the update, the compatibility compile and feature-removal flow can run without the required removal set and miss cleanup work before the upgrade continues.
| $oWizard->SetParameter('upgrade_type', 'use-compatible'); | ||
|
|
||
| $oWizard->SaveParameter('use_symbolic_links', MFCompiler::UseSymbolicLinks()); | ||
| $oWizard->SaveParameter('use_symbolic_links', MFCompiler::UseSymbolicLinks() ? 'on' : 'off'); |
There was a problem hiding this comment.
seems like a bug fix not related to current enhancement, right?
| <input type="hidden" name="_params[authent]" value="{$this->sUID}"/> | ||
| <table style="width:100%;" class="ibo-setup--wizard--buttons-container"> | ||
| <tr> | ||
| <td style="text-align: right"><button type="submit" class="ibo-button ibo-is-regular ibo-is-secondary">Keep current choices</button></td> |
There was a problem hiding this comment.
maybe a tooltip to detail what will happen if user clicks on this button?
There was a problem hiding this comment.
this button is so powerfull that I would change his color to highlight it!
odain-cbd
left a comment
odain-cbd
left a comment
There was a problem hiding this comment.
thank you for this enhancement. so much time will be sparred!
3 participants
Add a fast track button to the first setup screen to compile iTop with the current choices (only on update)