Skip to content

N°9604 - Add Flux tab on Server, VM and ContainerApplication#918

Merged
v-dumas merged 2 commits into
developfrom
feature/9604-Flux-on-Server-VM-ContainerApp
May 27, 2026
Merged

N°9604 - Add Flux tab on Server, VM and ContainerApplication#918
v-dumas merged 2 commits into
developfrom
feature/9604-Flux-on-Server-VM-ContainerApp

Conversation

@v-dumas
Copy link
Copy Markdown
Contributor

@v-dumas v-dumas commented May 26, 2026

Base information

Question Answer
Related to a Combodo ticket? N°9604 - latest feedbacks
Type of change? Enhancement

Symptom (bug) / Objective (enhancement)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand without digging in the code?

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 26, 2026

Greptile Summary

This PR extends the flow-map module to more CI classes and updates its seed data. The main changes are:

  • Adds the data flows dashboard tab to Server, VirtualMachine, and ContainerApplication.
  • Reorders the data flows tab across existing flow-map CI presentations.
  • Adds FTPS to the seeded data flow types.
  • Updates the module dependency expression for structure, virtualization, and container modules.

Confidence Score: 3/5

These issues should be fixed before merging.

  • The FTPS seed entry reuses an existing XML id, so one of the seeded typologies can be lost or the import can fail.

  • The uppercase protocol name changes can split existing typology data on upgrade.

  • The presentation changes look contained after checking the affected class tabs.

  • datamodels/2.x/itop-flow-map/data/en_us.data.itop-flow-map.xml

Important Files Changed

Filename Overview
datamodels/2.x/itop-flow-map/data/en_us.data.itop-flow-map.xml Updates seeded flow type names and adds FTPS, with import and upgrade risks in the changed data.
datamodels/2.x/itop-flow-map/datamodel.itop-flow-map.xml Adds and reorders data flow dashboard tab placement for selected CI classes.
datamodels/2.x/itop-flow-map/module.itop-flow-map.php Adds optional dependency coverage for structure, virtualization, and container modules.

Reviews (1): Last reviewed commit: "N°9604 - Add Flux tab on Server, VM and ..." | Re-trigger Greptile

Comment thread datamodels/2.x/itop-flow-map/data/en_us.data.itop-flow-map.xml
Comment thread datamodels/2.x/itop-flow-map/data/en_us.data.itop-flow-map.xml
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@v-dumas v-dumas merged commit 51180c9 into develop May 27, 2026
@v-dumas v-dumas deleted the feature/9604-Flux-on-Server-VM-ContainerApp branch May 27, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants