N°9564 - Extension Mgmt : Analyse choices & show analysis result

[odain-cbd]

No description provided.

[greptile-apps]

Greptile Summary

This PR folds extension-removal analysis into the result page and updates setup module-choice handling. The main changes are:

• Directs the feature selection form to AnalysisResult instead of the old analyze step.
• Shows changed extension choices, cleanup plans, deletion execution, and setup launch controls in one Twig template.
• Adds compile error handling around the dry removal analysis.
• Changes runtime compilation dependency handling and wizard step cache behavior.
• Updates tests and a setup-audit simulation helper.

Confidence Score: 3/5

This should be fixed before merging.

• The back-office removal form can ignore the selected extension removals.

• The dry analysis compile can stop before producing the cleanup plan.

• A stale deletion form can still hit a runtime error instead of recovering cleanly.

• DataFeatureRemovalController.php

• runtimeenv.class.inc.php

Important Files Changed

Filename	Overview
datamodels/2.x/combodo-data-feature-removal/src/Controller/DataFeatureRemovalController.php	Merges analysis/result/deletion flow, but the direct form path can lose selected removals and stale deletion posts are not guarded.
setup/runtimeenv.class.inc.php	Changes dependency sorting to abort during compile, which can block dry feature-removal analysis.
datamodels/2.x/combodo-data-feature-removal/templates/AnalysisResult.html.twig	Combines feature choice display, deletion plan, execution summary, and setup launch controls.

Comments Outside Diff (1)

1. datamodels/2.x/combodo-data-feature-removal/src/Controller/DataFeatureRemovalController.php, line 279-286 (link)

   Stale deletion posts crash

   aDeletionExecutionSummary is removed from the session on the first deletion request, but this method still assumes it always unserializes to an array. A double-submit or browser back/resubmit after the first request makes Session::Get('aDeletionExecutionSummary') return an empty value, so $this->aDeletionExecutionSummary becomes false/null; the next array_key_exists() call then raises a TypeError instead of redisplaying a safe stale-form error.

_{Reviews (1): Last reviewed commit: "after merge adaptations" | Re-trigger Greptile}