Skip to content

chore: sync main into develop (back-merge HR 'Applied for' hotfix) #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rathorevaibhav wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

chore: sync main into develop (back-merge HR 'Applied for' hotfix) #3869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e71e968
Merge pull request #3852 from ColoredCow/develop
rathorevaibhav Jun 2, 2026
0f326dc
Merge pull request #3857 from ColoredCow/develop
rathorevaibhav Jun 4, 2026
bfe4171
fix: add "Applied for" job title to HR AI-evaluation copy
rathorevaibhav Jun 14, 2026
3b9c6d0
Merge pull request #3864 from ColoredCow/hotfix/hr-copy-ai-evaluation…
rathorevaibhav Jun 14, 2026
a29e4e7
Merge remote-tracking branch 'origin/main' into chore/sync-main-into-…
rathorevaibhav Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions Modules/HR/Tests/Feature/CopyForAiEvaluationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?php

namespace Modules\HR\Tests\Feature;

use Illuminate\Foundation\Testing\RefreshDatabase;
use Modules\HR\Entities\Applicant;
use Modules\HR\Entities\Application;
use Modules\HR\Entities\Job;
use Tests\TestCase;

class CopyForAiEvaluationTest extends TestCase
{
use RefreshDatabase;

public function test_clipboard_text_includes_applied_for_job_title()
{
$applicant = Applicant::factory()->create(['name' => 'Jane Doe']);
$job = Job::factory()->create(['title' => 'Senior Laravel Developer']);
$application = Application::factory()->create([
'hr_applicant_id' => $applicant->id,
'hr_job_id' => $job->id,
]);

$html = view('hr.application.copy-for-ai-evaluation', [
'applicant' => $applicant,
'application' => $application,
])->render();

$this->assertStringContainsString('Applied for: ' . $job->title, $html);
}
Comment on lines +15 to +30

@coderabbitai coderabbitai Bot Jun 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Test should also verify behavior when job is null.

The test verifies the happy path (job title present), but does not test the guard logic (optional() on line 6 of the template). A second test case should verify that the 'Applied for:' line does not appear when $application->job is null.

Consider adding a complementary test:

public function test_clipboard_text_omits_applied_for_when_no_job()
{
    $applicant = Applicant::factory()->create(['name' => 'John Doe']);
    $application = Application::factory()->create([
        'hr_applicant_id' => $applicant->id,
        'hr_job_id' => null,
    ]);

    $html = view('hr.application.copy-for-ai-evaluation', [
        'applicant' => $applicant,
        'application' => $application,
        'applicationFormDetails' => null, // Add missing variable
    ])->render();

    $this->assertStringNotContainsString('Applied for:', $html);
}
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Modules/HR/Tests/Feature/CopyForAiEvaluationTest.php` around lines 15 - 30,
Add a complementary test method to cover the null job scenario that the existing
test does not address. Create a new test method in the CopyForAiEvaluationTest
class that creates an Application with hr_job_id set to null (similar to the
existing test_clipboard_text_includes_applied_for_job_title method), passes the
required view variables including applicant and application to the view render
call, and then verifies using assertStringNotContainsString that the "Applied
for:" text does not appear in the rendered HTML output when no job is associated
with the application.

}
5 changes: 5 additions & 0 deletions resources/views/hr/application/copy-for-ai-evaluation.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
$clipboardLines[] = 'Candidate to evaluate:';
$clipboardLines[] = $applicant->name . ', applied on ' . $application->created_at->format(config('constants.display_date_format'));

$appliedForJobTitle = optional($application->job)->title;
if (!empty($appliedForJobTitle)) {
$clipboardLines[] = 'Applied for: ' . $appliedForJobTitle;
}

if (!empty($applicant->graduation_year)) {
$clipboardLines[] = 'Graduation Year: ' . $applicant->graduation_year;
}
Expand Down
Loading