Skip to content

Point ArgoCD at ordermanager-iac; fix stale monolith references#19

Open
devin-ai-integration[bot] wants to merge 2 commits into
mainfrom
devin/1783565759-argocd-repourl
Open

Point ArgoCD at ordermanager-iac; fix stale monolith references#19
devin-ai-integration[bot] wants to merge 2 commits into
mainfrom
devin/1783565759-argocd-repourl

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Makes the GitOps deployment for the OrderManager monolith actually resolve. The ArgoCD Applications pointed at a repo that no longer exists (pre-rename app_dotnet-angular-monolith-iac), and the reference Dockerfile/CI pointed at the old app repo name and had a broken Angular copy path.

Changes

  • argocd/application-{dev,staging}.yamlrepoURLhttps://github.com/Cognition-Partner-Workshops/ordermanager-iac.git (this repo, where the Helm chart lives). Without this, ArgoCD can't sync the chart.
  • ci/build-push.yaml — reference workflow now checks out Cognition-Partner-Workshops/ordermanager-monolith (was app_dotnet-angular-monolith), and runs dotnet test before the build/push so a failing test can't push a broken image.
  • docker/Dockerfile — corrected the reference build so it works against the monolith repo:
    • Angular output copy path dist/client-app/browsersrc/OrderManager.Api/wwwroot/browser (Angular 17 application builder output per the app's angular.json).
    • npm ci retained (the app repo now commits package-lock.json).

Context

The executing CI workflow lives in the monolith repo (ordermanager-monolith/.github/workflows/build-push.yaml) and pushes dev-latest/staging-latest, which the value overrides here pin via image.tag. ci/build-push.yaml here remains the platform reference/template. The ECR repo workshop/ordermanager and OIDC role github-actions-ecr-push were provisioned in AWS (they didn't exist) reusing the existing GitHub OIDC provider.

Helm renders cleanly for both envs (helm template with values.yaml + values-dev.yaml/values-staging.yaml).

Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/d037c53ae9c947cdbd6e73c95a4ae62d
Requested by: @mbatchelor81


Open in Devin Review

@mbatchelor81 mbatchelor81 self-assigned this Jul 9, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

Open in Devin Review

Comment thread ci/build-push.yaml
Comment thread docker/Dockerfile Outdated
Comment thread docker/Dockerfile
RUN dotnet restore
COPY . .
COPY --from=client-build /app/client/dist/client-app/browser src/OrderManager.Api/wwwroot/
COPY --from=client-build /app/src/OrderManager.Api/wwwroot/browser src/OrderManager.Api/wwwroot/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Dockerfile Angular output path depends on angular.json configuration in a separate repository

The COPY source path changed from /app/client/dist/client-app/browser (standard Angular CLI default output) to /app/src/OrderManager.Api/wwwroot/browser (docker/Dockerfile:18). This new path assumes the Angular project's angular.json has a custom outputPath set to ../src/OrderManager.Api/wwwroot. If the ordermanager-monolith app repo's angular.json doesn't have this exact configuration, the Docker build will fail at this COPY step. The comment on line 7 documents this assumption, but it cannot be verified from this repo alone.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed against the app repo: ordermanager-monolith/client-app/angular.json sets outputPath: ../src/OrderManager.Api/wwwroot and the Angular 17 application builder emits into a browser/ subfolder, so the assets land at /app/src/OrderManager.Api/wwwroot/browser. I verified end-to-end with a real docker build — it succeeds and the container serves /, /health, and /api/products (all 200). The prior dist/client-app/browser path did not exist and the build failed at that COPY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant