Improve compact feature recommendation panel in onboarding - #500
Conversation
There was a problem hiding this comment.
Pull request overview
Compacts and simplifies the onboarding feature recommendation panel.
Changes:
- Tightens panel and feature-card spacing.
- Consolidates Otter recommendations.
- Shortens plugin descriptions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
onboarding/src/scss/_site-settings.scss |
Adds compact feature-step styling. |
onboarding/src/scss/_features_list.scss |
Restyles feature cards and layout. |
onboarding/src/Components/SiteSettings.js |
Applies feature-step-specific class. |
onboarding/src/Components/FeaturesList.js |
Consolidates recommendations and shortens descriptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| display: flex; | ||
| flex-direction: column; | ||
| width: 100%; | ||
| overflow-x: hidden; |
Soare-Robert-Daniel
left a comment
There was a problem hiding this comment.
@harshitarora-in can you check if the E2E also need to be updated?
|
@copilot Can you review this PR and make sure it won't fail the E2E tests? If the tests need to be updated because of these changes, please update them. Also, can you check whether this PR satisfies the following checklist items?
If you find anything that needs to be updated, please make the necessary changes and explain what you changed. |
Descriptions now render expanded and collapse only when the card list would run past the footer, so the panel no longer needs scrolling on short viewports. Each card gets a chevron toggle that reuses the title for its accessible name, and selected features give up their description first since unselected ones still need the pitch. Updates the e2e selectors to target the new markup via data-plugin and relaxes the card count assertion, as the collection is now five entries.
7b1c0b6 to
cc30a46
Compare
|
@Soare-Robert-Daniel, with the old implementation, it was introducing multiple new strings. To avoid that, I changed the implementation a bit by adding an expandable card while keeping the existing string unchanged.
|

Summary
This PR improves the onboarding feature recommendation panel to make it more compact and easier to scan, while keeping the existing selection behavior intact.
Changes included:
Will affect visual aspect of the product
YES
Screenshots
Test instructions
Expected Result
Check before Pull Request is ready:
Closes #.