azure-sap-zone: new resource agent for Azure SAP zone alignment by sanoop-t · Pull Request #2122 · ClusterLabs/resource-agents

sanoop-t · 2026-01-30T20:39:23Z

PR Summary

This PR adds a new Python-based OCF resource agent under heartbeat/ named azure-sap-zone. The agent helps align SAP application-server activity with the active (PROMOTED) HANA node’s Azure Availability Zone (or a logical “zone group” for non-zonal/PPG deployments), to reduce cross-zone latency and to automate app-tier switching during HANA failover.

Key behavior

Runs under Pacemaker as a cloned resource and acts only when the local HANA node is PROMOTED (primary).
Determines the “active zone/group” from:
- Azure IMDS zone metadata (zonal deployments), or
- hana_vm_zones mapping (non-zonal/PPG deployments).
Ensures app VMs in the same zone/group are started and SAP is started/activated.
For app VMs in the other zone/group:
- stop_vms=false: deactivates SAP (passive mode) without stopping VMs.
- stop_vms=true: stops SAP, waits for shutdown, then deallocates those VMs.

Notable parameters

hana_resource (required): Pacemaker HANA resource name used to read status attributes.
App VM selection: provide at least one of:
- app_vm_names (comma-separated), or
- app_vm_name_pattern (regex), or
- app_vm_zones (mapping; can also supply names).
Non-zonal/PPG mappings:
- hana_vm_zones="hanavm1:1,hanavm2:2"
- app_vm_zones="sapapp01:1,sapapp02:1,sapapp03:2,..."
Managed Identity:
- client_id (optional): user-assigned MI; if omitted, system-assigned MI is used.
Operational controls:
- stop_vms, wait_before_stop_sap, wait_time, soft_shutdown_timeout
- retry_count, retry_wait for ARM API retries

Safety/correctness notes

Fail-fast validation on start: when app_vm_zones/hana_vm_zones are provided and Azure zone metadata exists, the agent verifies the mapping matches Azure and fails early on mismatch.
Uses managed identity token caching with expiry tracking + refresh.
ARM calls include retries for common transient failures (429/5xx).
Uses stable VM power-state codes (PowerState/*) from instanceView.
Azure Run Command execution includes a payload variation to avoid stale cached results when reusing a fixed runCommand name.

Dependencies / packaging

requests is treated as an optional import so meta-data discovery can still work; Azure API operations require python3-requests.

Testing / validation performed

Verified meta-data output generation and validate-all parameter validation paths.
Reviewed monitor/start/stop flows for zone resolution, app VM selection, and stop/deallocate logic.

Notes

Script currently ships with the upstream-style shebang placeholder #!@PYTHON@ -tt (consistent with other Python agents that are patched/installed by packaging or install instructions).

knet-jenkins · 2026-01-30T20:40:09Z

Can one of the project admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-2122/1/input

sanoop-t · 2026-02-13T15:31:57Z

Hi @oalbrigt I noticed the PR was moved to draft a few days ago. I didn’t see any comments, so I just wanted to check if there’s anything specific, you’d like me to address or if more work is needed before review. Happy to make updates. Thanks!

oalbrigt · 2026-02-16T13:11:45Z

We are discussing where it would make most sense to host this. If it would be with the SAP agents, or in this repo.

I'll come back to you when we have made a decission.

sanoop-t · 2026-03-04T15:51:51Z

@oalbrigt Hello, please let me know if there are any updates from your discussion.

sanoop-t · 2026-03-19T00:41:25Z

@oalbrigt Hello, following up on this. Let me know if there are any updates from your discussion.

oalbrigt · 2026-03-19T14:44:35Z

I'm still waiting for an update from our internal discussion, and have asked for an update again.

sanoop-t · 2026-04-01T22:29:51Z

@oalbrigt Hello, let me know if there are any updates from your discussion.

oalbrigt · 2026-04-10T10:59:38Z

@sanoop-t We've decided to merge it here. So I'll do a full review next week.

From a quick glance you have to add it to the Makefile.am files, and configure.ac to not build it when Python isnt new enough or similar situations arise during the build process.

See https://github.com/ClusterLabs/resource-agents/blob/main/doc/dev-guides/ra-dev-guide.asc#submitting-resource-agents for more info.

knet-jenkins · 2026-04-13T15:03:18Z

Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/resource-agents/job/resource-agents-pipeline/job/PR-2122/2/input

Add azure-sap-zone to configure.ac, heartbeat/Makefile.am, doc/man/Makefile.am, and .gitignore following the existing azure-events pattern. The agent is conditionally built when Python 3.6+ is available.

knet-jenkins · 2026-04-13T15:07:54Z

Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/resource-agents/job/resource-agents-pipeline/job/PR-2122/3/input

sanoop-t · 2026-04-13T15:10:25Z

Thanks @oalbrigt! I've updated the PR with the build system integration:

Added conditional build block in configure.ac (Python 3.6+ check)
Added azure-sap-zone to ocf_SCRIPTS in heartbeat/Makefile.am
Added man page entry in doc/man/Makefile.am
Added generated file to .gitignore

All following the existing azure-events pattern. Ready for your full review whenever you get a chance.

oalbrigt · 2026-04-14T12:54:54Z

Great. Thanks.

Remove the _OCFShim fallback class and custom OCF path-searching logic. Use the standard ocf.py import pattern consistent with other Python agents in the repository. Remove the custom _is_probe_operation() function in favor of ocf.is_probe(). Adjust validate_action to handle string parameter values from the ocf.py run loop.

knet-jenkins · 2026-04-16T16:32:53Z

Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/resource-agents/job/resource-agents-pipeline/job/PR-2122/4/input

oalbrigt

Looks good in general.

Just a bashism that's nice to get rid of.

Replace [[ ... == *OK* ]] pattern match with a POSIX-compatible case/esac construct for better portability across sh implementations.

knet-jenkins · 2026-04-21T17:39:09Z

Can one of the project admins check and authorise this run please: https://haci.fast.eng.rdu2.dc.redhat.com/job/resource-agents/job/resource-agents-pipeline/job/PR-2122/5/input

oalbrigt · 2026-04-23T07:29:37Z

Thanks.

Initial import: Azure SAP zone alignment Pacemaker/OCF resource agent

2ae1f96

oalbrigt marked this pull request as draft February 9, 2026 07:04

sanoop-t marked this pull request as ready for review February 12, 2026 18:26

Low: azure-sap-zone: add build system integration

1060cc6

Add azure-sap-zone to configure.ac, heartbeat/Makefile.am, doc/man/Makefile.am, and .gitignore following the existing azure-events pattern. The agent is conditionally built when Python 3.6+ is available.

sanoop-t force-pushed the sanoopt_azure-sap-zone branch from 2cfa0e7 to 1060cc6 Compare April 13, 2026 15:07

oalbrigt reviewed Apr 16, 2026

View reviewed changes

Comment thread heartbeat/azure-sap-zone.in Outdated

oalbrigt reviewed Apr 16, 2026

View reviewed changes

Comment thread heartbeat/azure-sap-zone.in Outdated

oalbrigt requested changes Apr 21, 2026

View reviewed changes

Comment thread heartbeat/azure-sap-zone.in Outdated

Low: azure-sap-zone: replace bash-specific [[ ]] with POSIX case

70af069

Replace [[ ... == *OK* ]] pattern match with a POSIX-compatible case/esac construct for better portability across sh implementations.

oalbrigt reviewed Apr 22, 2026

View reviewed changes

Comment thread heartbeat/azure-sap-zone.in

oalbrigt changed the title ~~Initial import: Azure SAP zone alignment Pacemaker/OCF resource agent~~ azure-sap-zone: new resource agent for Azure SAP zone alignment Apr 23, 2026

oalbrigt approved these changes Apr 23, 2026

View reviewed changes

oalbrigt merged commit 78cea62 into ClusterLabs:main Apr 23, 2026
1 check passed

Conversation

sanoop-t commented Jan 30, 2026

PR Summary

Key behavior

Notable parameters

Safety/correctness notes

Dependencies / packaging

Testing / validation performed

Notes

Uh oh!

knet-jenkins Bot commented Jan 30, 2026

Uh oh!

sanoop-t commented Feb 13, 2026

Uh oh!

oalbrigt commented Feb 16, 2026

Uh oh!

sanoop-t commented Mar 4, 2026

Uh oh!

sanoop-t commented Mar 19, 2026

Uh oh!

oalbrigt commented Mar 19, 2026

Uh oh!

sanoop-t commented Apr 1, 2026

Uh oh!

oalbrigt commented Apr 10, 2026

Uh oh!

knet-jenkins Bot commented Apr 13, 2026

Uh oh!

knet-jenkins Bot commented Apr 13, 2026

Uh oh!

sanoop-t commented Apr 13, 2026

Uh oh!

oalbrigt commented Apr 14, 2026

Uh oh!

Uh oh!

Uh oh!

knet-jenkins Bot commented Apr 16, 2026

Uh oh!

oalbrigt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

knet-jenkins Bot commented Apr 21, 2026

Uh oh!

Uh oh!

Uh oh!

oalbrigt commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants