Fix negative seconds in submission countdown timer#5146
Open
shivamsingh-007 wants to merge 2 commits into
Open
Fix negative seconds in submission countdown timer#5146shivamsingh-007 wants to merge 2 commits into
shivamsingh-007 wants to merge 2 commits into
Conversation
Decrement remaining_time on the source object instead of the formatted display string, and guard with <= 0 instead of === 0 to prevent the timer from showing negative values at zero. Fixes Cloud-CV#4594
After the countdown timer fix, vm.remainingTime holds the value copied from source before the decrement, so assertions must compare against constants rather than the mutated source property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix negative seconds appearing in the submission countdown timer when
remaining time reaches zero.
Related Issue
Fixes #4594
What changed
display string) with \�m.remainingTime--\ (numeric counter) in both
countdown timers; changed === 0\ guard to <= 0\ to prevent
negative values at the transition point
source value instead of referencing the mutated property
Why this approach
The original code decremented the display-formatted string
(\�m.remainingSeconds) instead of the actual numeric counter
(\�m.remainingTime), and the guard used strict equality (=== 0)
which allowed the counter to go negative. Fixing both the decrement
target and the guard resolves the reported issue.
Testing done
pm test\ (gulp dev + karma + Chrome headless): 600/600 pass
(13 assertions covering countdown, zero transition, edge cases)
Checklist