Open
Conversation
|
can we have this merged please? @thomasrebam did you by chance did an npm release for the mean time? |
|
When it will be merge. We wait it feature. Thanks for pr. |
|
@thomasrebam is there a chance to include the code to make the D_PAD work? I have the sample code here #4 |
As Expo 50 is now using React Native 0.73 that uses MainActivity.kt and not MainActivity.java anymore
thomasrebam
force-pushed
the
main
branch
2 times, most recently
from
625415b to
c89a701
Compare
Author
|
We published a patch here We didn't have time to check your patch @silencer07, so we did not add it to the fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Expo SDK 50 was published, we would need to be able to use this plugin, with the modifications that appear in this PR.
Indeed, as mentioned in the Expo SDK 50 changelog, they use React Native 0.73 version, where MainActivity file is not in Java anymore but in Kotlin. Therefore, changes in the withReactNativeKeyevent are needed if we want to use Expo 50.