feat: exposes multiple maps - #18
Open
bellaz89 wants to merge 3 commits into
Open
Conversation
Member
|
Other than that now allocates quite a lot of memory looks fine to me- cherry on top would maybe a module parameter to define the number of maps, but that isn't crucial at all |
Author
I reduced the default maps size for map0 and map2. I also add a module parameter to define the number of parameters. |
bellaz89
changed the title
Member
|
This needs to be merged with the changes to DeviceAccess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR extends the number of dummy maps. The default number of maps is 3. This is needed to test the UIO backend multiple-maps support.
Related to ChimeraTK/DeviceAccess#563