Fix cargo-fuzz install breakage on nightly#358
Merged
Conversation
Keep the locked cargo-fuzz install for reproducibility, but fall back to an unlocked install when nightly toolchain changes break the lockfile dependency graph. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
Root-cause research for the Rust fuzzer CI failuresI investigated the failing What fails in CI
Upstream confirmation
Why this affects this repository
Why this PR fix works
|
Add an explicit callable list annotation for BUILD_HOOKS so strict mypy no longer flags it as an untyped module variable in setup.py. Co-authored-by: Cursor <cursoragent@cursor.com>
cmmarslender
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo +nightly install cargo-fuzz --lockedpath for reproducibility.Test plan
Install cargo-fuzz.rust.ymlfuzzer install behavior.Run fuzzers (*)jobs pass in CI on this PR.Made with Cursor
Note
Low Risk
Low risk: changes are limited to CI tooling installation behavior and a Python typing annotation, with no runtime/library logic modifications.
Overview
Fixes nightly CI fuzz jobs by making
cargo-fuzzinstallation resilient: keepcargo +nightly install cargo-fuzz --lockedfor reproducibility, but fall back to an unlocked install if the locked path fails.Also adds a small typing improvement in
setup.pyby annotatingBUILD_HOOKSas alist[Callable[..., None]](and importingCallable).Reviewed by Cursor Bugbot for commit a52f824. Bugbot is set up for automated code reviews on this repo. Configure here.