Skip to content

👷 Enable run cli test for wasip2 target#2632

Draft
ChanTsune wants to merge 1 commit into
mainfrom
ci/wasip2
Draft

👷 Enable run cli test for wasip2 target#2632
ChanTsune wants to merge 1 commit into
mainfrom
ci/wasip2

Conversation

@ChanTsune
Copy link
Copy Markdown
Owner

@ChanTsune ChanTsune commented Jan 22, 2026

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to adjust test target compatibility settings.

✏️ Tip: You can customize this high-level summary in your review settings.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@ChanTsune ChanTsune marked this pull request as draft January 22, 2026 01:32
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 665112bf-b3b8-4d09-822f-eaaeea0d9541

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

A GitHub Actions workflow conditional is updated to target wasm32-wasi instead of wasm32-wasip1 when determining whether to execute the test Run step. This is a single-line configuration adjustment affecting conditional logic for Rust nightly wasm builds.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/webassembly.yml
Updated test Run step conditional from wasm32-wasip1 to wasm32-wasi target matching for Rust nightly builds

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

CI, cli

Poem

🐰 A tiny hop through workflows so grand,
From wasip1 to wasi, we take our stand,
One line changed, so clean and neat,
Now wasm32 will dance to a different beat! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims to enable tests for 'wasip2', but the actual change modifies the condition from 'wasm32-wasip1' to 'wasm32-wasi', not 'wasip2'. The title is misleading about what the changeset accomplishes. Update the title to accurately reflect the change, such as 'Enable run cli test for wasm32-wasi target' to match the actual implementation.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/wasip2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the CI Pull requests that update CI config label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Pull requests that update CI config

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant