Skip to content

✅ Add comprehensive tests for extract owner options #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChanTsune wants to merge 2 commits into
base: main
Choose a base branch
from
Open

✅ Add comprehensive tests for extract owner options #2596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0830c53
:white_check_mark: Add comprehensive tests for extract owner options
ChanTsune Jan 11, 2026
0633665
:recycle: Move skip_if_not_root macro to shared utils
ChanTsune Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cli/tests/cli/extract.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ mod option_keep_old_files;
mod option_keep_permission;
mod option_keep_timestamp;
mod option_mtime;
mod option_owner;
mod option_password_from_file;
mod option_safe_writes;
mod option_substitution;
Expand Down
6 changes: 2 additions & 4 deletions cli/tests/cli/extract/option_chroot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#![cfg(all(unix, not(target_family = "wasm")))]
use crate::utils::unix::skip_if_not_root;
use crate::utils::{EmbedExt, TestResources, setup};
use assert_cmd::cargo::cargo_bin_cmd;
use std::fs;
Expand All @@ -8,10 +9,7 @@ use std::fs;
/// Expectation: Absolute output path is resolved relative to chroot root, not filesystem root.
#[test]
fn archive_extract_chroot() {
// chroot need root privileges
if !nix::unistd::Uid::effective().is_root() {
return;
}
skip_if_not_root!();
setup();
TestResources::extract_in("zstd.pna", "extract_chroot/").unwrap();

Expand Down
Loading
Loading