💥 Change --password-file behavior#2156
Draft
ChanTsune wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
cli
ChanTsune
force-pushed
the
cli/password-read-strategy
branch
from
5e052b7 to
cd0e0bc
Compare
ChanTsune
force-pushed
the
cli/password-read-strategy
branch
from
cd0e0bc to
7836e51
Compare
github-actions
Bot
added
break
Previously, the entire file content was used as the password. Now, only the first non-empty line is read, and trailing newlines are ignored, to align with common tool behavior.
ChanTsune
force-pushed
the
cli/password-read-strategy
branch
from
7836e51 to
f03b0e5
Compare
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
break
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the entire file content was used as the password. Now, only the first non-empty line is read, and trailing newlines are ignored, to align with common tool behavior.