⚡ SolidEntryBuilder::build return type io::Result<impl Entry> to io::Result<SolidEntry>

[ChanTsune]

Summary by CodeRabbit

• API Changes
  • Refined return type specification in the public interface for improved clarity and specificity.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f1a4a4b0-27b3-4d67-9595-cf20409bef53

📥 Commits

Reviewing files that changed from the base of the PR and between 7f12664 and f0f30eb.

📒 Files selected for processing (1)

• lib/src/entry/builder.rs

---

📝 Walkthrough

Walkthrough

SolidEntryBuilder::build method signature changes to return a concrete SolidEntry type instead of an opaque impl Entry + Sized trait object, making the return type explicit in the public API while preserving the internal implementation delegation.

Changes

Builder return type concretization

Layer / File(s)	Summary
Builder method return type signature lib/src/entry/builder.rs	SolidEntryBuilder::build return type updated from impl Entry + Sized to the concrete SolidEntry type, changing the public API contract.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• ChanTsune/Portable-Network-Archive#2533: Modifies the same SolidEntryBuilder::build function signature and attributes (adds #[must_use]), directly overlapping at the same API surface.

Poem

A builder bold shed its disguise,
No longer hiding—crystal clear and wise,
Concrete paths where opaque once lay,
The entry type now shines in light of day! 🐰✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: updating the return type of SolidEntryBuilder::build from io::Result<impl Entry> to io::Result<SolidEntry>.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch lib/SolidEntryBuilder-build-publish-return-type

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}