MoleculeNet Classification Data : Modularization, dynamic splits, Clean Code#174
Draft
aditya0by0 wants to merge 34 commits into
Draft
MoleculeNet Classification Data : Modularization, dynamic splits, Clean Code#174aditya0by0 wants to merge 34 commits into
aditya0by0 wants to merge 34 commits into
Conversation
Member
Author
|
@sfluegel05, once I complete the gnn experiments with molecule net dataset, then we could merge the PR. Until then we could keep this PR in the draft state. |
* Rename 'val' to 'validation' in data splits * Update chebi-utils version requirement in pyproject.toml
…hEB-AI/python-chebai into fix/molecule_net_dynamic_split
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes related to Molecule Net classification introduced in #130
General Changes
Check before dataloader to assert if the data is empty (as pytorch or lightning doesn't check this)
Generalize _DynamicDataset class to all datasets by replacing
_graph_to_raw_datasetto_preprocess_data_into_dataframeModularize splitting logic into separate classes (so we dont need to specifiy the split logic for every new data class, rather just inherent the required splitting logic class )
Suggested Metric as per data type by https://arxiv.org/abs/1703.00564 for Molecule Net dataset