added user link to dashboard download file#11824
Open
ihorsokhanexoft wants to merge 4 commits into
Open
Conversation
brianjgeiger
changed the base branch from
feature/pbs-26-13
to
feature/pbs-26-15
July 23, 2026 13:06
sh-andriy
requested changes
Jul 24, 2026
sh-andriy
left a comment
sh-andriy
left a comment
Collaborator
There was a problem hiding this comment.
@ihorsokhanexoft source='absolute_url' looks for that attribute on the MonthlyInstitutionalUserReport ES doc, which doesn't have one — DRF hits SkipField (read_only ⇒ required=False) and drops the column silently, so the CSV is unchanged. I applied this locally and test_get_report_formats_csv_tsv still passes even though it asserts the exact header, which is why CI is green. Could you switch to a SerializerMethodField returning urljoin(website_settings.DOMAIN, f'/{obj.user_id}/') (both imports need adding) and add link to the CSV+TSV header/row assertions in that test?
ihorsokhanexoft
force-pushed
the
fix/ENG-11795
branch
from
July 24, 2026 14:09
a048ead to
84b6fe2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://openscience.atlassian.net/browse/ENG-11795