Skip to content

[ENG-10829] Embargoed Registration — End Embargo Early Button Missing #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkovalua wants to merge 7 commits into
base: feature/pbs-26-12
Choose a base branch
from
Open

[ENG-10829] Embargoed Registration — End Embargo Early Button Missing #982

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5f75cff
show registry.overview.endEmbargo for registration status if it is no…
mkovalua May 6, 2026
c2b5849
resolve linter errors
mkovalua May 6, 2026
68bcd2a
resolve CR
mkovalua Jul 7, 2026
93f41ff
resolve CR
mkovalua Jul 7, 2026
6c6c276
Update src/app/features/registry/components/registry-statuses/registr…
mkovalua Jul 7, 2026
821febf
resolve linter issues
mkovalua Jul 7, 2026
31fb6d7
update code
mkovalua Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/app/features/registry/components/registry-statuses/registry-statuses.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
<p-accordion class="accordion-border px-4 py-4 flex-1 no-padding">
<p-accordion-panel value="0">
<p-accordion-header class="flex flex-row column-gap-3 align-items-center">
<p class="font-bold">{{ 'registry.overview.statuses.' + registry()?.status + '.text' | translate }}</p>
<p class="font-bold">{{ statusTranslations().text | translate }}</p>
</p-accordion-header>

<p-accordion-content>
<div class="flex flex-column pt-4 gap-2">
<h3 class="font-normal">{{ 'registry.overview.statuses.' + registry()?.status + '.short' | translate }}</h3>
<h3 class="font-normal">{{ statusTranslations().short | translate }}</h3>
<p>
<span>
{{
'registry.overview.statuses.' + registry()?.status + '.long'
| translate: { embargoEndDate: embargoEndDate(), email: supportEmail }
}}
{{ statusTranslations().long | translate: { embargoEndDate: embargoEndDate(), email: supportEmail } }}
</span>

@if (isAccepted()) {
Expand Down
17 changes: 17 additions & 0 deletions src/app/features/registry/components/registry-statuses/registry-statuses.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,23 @@ export class RegistryStatusesComponent {
return date ? new Date(date).toDateString() : null;
});

statusTranslations = computed(() => {
const status = this.registry()?.status;
if (!status) {

@adlius adlius Jul 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked RegistryStatusEnum and the None value is "None" which is a truthy string. If that's the case then this wouldn't fix it. Could you double check?

@mkovalua mkovalua Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adlius, @Nazar690, I have updated

FYI: also not confident whether it is the best workflow, because not confident why 'None' may exists in database for registration that is needed to be embargoed

https://openscience.atlassian.net/browse/ENG-10829?focusedCommentId=119253
.

Maybe it is better to have another one workflow it is None , set another messages and do another UI workflow

https://openscience.atlassian.net/browse/ENG-10829?focusedCommentId=119253

image

, thanks

@mkovalua mkovalua Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nsemets

@nsemets nsemets Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adlius Is it End embargo early right text for None status?

return {
text: 'registry.overview.endEmbargo',
short: 'registry.overview.endEmbargo',
long: 'registry.overview.endEmbargo',
};
}
const basePath = `registry.overview.statuses.${status}`;
return {
text: `${basePath}.text`,
short: `${basePath}.short`,
long: `${basePath}.long`,
};
});
Comment thread
mkovalua marked this conversation as resolved.

openWithdrawDialog(): void {
const registry = this.registry();

Expand Down
Loading